262949 - DM should ask for a filename if one isn't provided

Status: RESOLVED INCOMPLETE

(Toolkit :: Downloads API, defect)

Description

[Alex Vincent [:WeirdAl]]

Spun off of bug 259708, which was a critical bug.  This one is much less serious.

Basically, the default filename given, "unnamed", is hardly ideal.  biesi thinks
it should be localized.  I think we should actually ask for a file name,
preferably with a file picker.

Suggestions welcome.  This is code I'm not familiar with, and neither is the
file picker.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

if ffox actually asks for a filename, it still should have a default name; and
if that's some "unnamed" equivalent it ought to be localizable.


if this should be fixed (I'm not sure whether it should, since the point of
autodownload is not to ask for filenames), the if at:
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in#194
probably needs to include a condition for "emtpy filename" or something

Comment 2

[Alex Vincent [:WeirdAl]]

cc'ing bsmedberg for possible localization issue.

Comment 3

[Benjamin Smedberg]

This is too late/risky for 1.0, let's leave it be on the branch and come up with
better solutions for the trunk.

Comment 4

[Matthew T (active 1999-2002)]

Since you'll need a default filename even if you have a filepicker, 
localizing that name should be a separate bug.

Less annoying than a filepicker (but, naturally, harder to implement) would 
be to allow renaming of downloads, during or after the download.

Comment 5

[Shawn Wilsher :sdwilsh]

this still an issue?

Comment 6

[kiran]

I am unable to open firefox on my XP when it automatically upgraded. I get error ** ERROR Installing File: D:\PROGRAMS\mozi\components\nsHelperAppDlg.js ** . I am unable to delete older version also

Comment 7

[Wayne Mery (:wsmwk)]

ostgote!  perhaps bug 259708 comment 1 is a testcase. what do you think?

Comment 8

[Tyler Downer [He/Him]]

@Reporter, we have not heard back from you in a while, so I am closing this bug as INCOMPLETE. You can reopen this bug if more information becomes available. Some helpful information you can provide us is found at http://quality.mozilla.org/bug-writing-guidelines. You should also use a recent version of Firefox, from http://www.getfirefox.com.