262964 - nsRange::InsertNode fails because of nsGenericDOMDataNode::SplitText

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alexandre Trémon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a4) Gecko/20040927
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a4) Gecko/20040927

SplitText calls CloneContent.
CloneContent implementation has been changed (see bug 27382)

Reproducible: Always
Steps to Reproduce:
In an app embedding Gecko:

#include "nsIDOMDocument.h"
#include "nsIDOMDocumentRange.h"
#include "nsIDOMElement.h"
#include "nsIDOMRange.h"
#include "nsIDOMNode.h"
#include "nsIDOMText.h"
#include "nsISelection.h"
#include "nsIDOMWindow.h"

nsresult rv;
nsIDOMDocument* domDoc;
mWebNav->GetDocument(&domDoc);
//
nsCOMPtr<nsIDOMElement> domElement;
domDoc->CreateElement(NS_LITERAL_STRING("b"), getter_AddRefs(domElement));
nsCOMPtr<nsIDOMText> domText;
domDoc->CreateTextNode(NS_LITERAL_STRING("insert me"), getter_AddRefs(domText));
//
nsCOMPtr<nsIDOMWindow> domWindow;
mWebBrowser->GetContentDOMWindow(getter_AddRefs(domWindow));
nsCOMPtr<nsISelection> selection;
domWindow->GetSelection(getter_AddRefs(selection));
//
nsCOMPtr<nsIDOMRange> domRange;
PRInt32 c;
selection->GetRangeCount(&c);
selection->GetRangeAt(0, getter_AddRefs(domRange));
//
domRange->InsertNode(domElement);
nsCOMPtr<nsIDOMNode> dummyNode;
domElement->AppendChild(domText, getter_AddRefs(dummyNode));
Actual Results:  
InsertNode calls nsGenericDOMDataNode::SplitText that fails on
nsGenericDOMDataNode::CloneContent.

Comment 1

[Alexandre Trémon]

Attachment: added virtual for cloneContent

Comment 2

[Alexandre Trémon]

Attachment: wrong file

Comment 3

[Boris Zbarsky [:bzbarsky]]

That patch has been on the trunk since September 16.  See revision 3.90 of
nsGenericDOMDataNode.h.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 161141 [details] [diff] [review]
wrong file

For future reference, you would need to fix the whitespace so the lines line up
right too...