When createing tables, Bugzilla should specify table type. I just installed MySql 4.1.5 gamma on Windows and the default table type is InnoDB, which doesn't support FULLTEXT.. DBD::mysql::db do failed: The used table type doesn't support FULLTEXT indexes at checksetup.pl line 2035
Created attachment 161266 [details] [diff] [review] explicitly set table type to MyISAM
Assignee: zach → bugzilla
Status: NEW → ASSIGNED
Summary: When createing tables, Bugzilla should specify table type as MyISAM → When creating tables, Bugzilla should specify table type as MyISAM
Comment on attachment 161266 [details] [diff] [review] explicitly set table type to MyISAM Does this work on the minimal version of MySQL 3 we require as well? If so, r=kiko (though could it be that we want to create only a certain group of tables as ISAM given that fulltext doesn't work over all of them?)
Attachment #161266 - Flags: review? → review+
# mysql -p Enter password: Welcome to the MySQL monitor. Commands end with ; or \g. Your MySQL connection id is 28993 to server version: 3.23.41-log Type 'help;' or '\h' for help. Type '\c' to clear the buffer. mysql> create database testdb; Query OK, 1 row affected (0.01 sec) mysql> connect testdb; Connection id: 28994 Current database: testdb mysql> create table test (a int) type = myisam; Query OK, 0 rows affected (0.00 sec) mysql> drop database testdb; Query OK, 3 rows affected (0.00 sec) mysql> quit Bye
We have code somewhere in checksetup.pl already that converts tables to MyISAM if they aren't (older versions defaulted to ISAM instead of MyISAM, which had problems with the number of indexes on the bugs table iirc). As long as someone can vouch that this doesn't conflict with that at all, I'm fine with this.
This ought to go in 2.16 as well (compatibility issue). 2.16 doesn't use fulltext indexes, but there's enough other differences between MyISAM and InnoDB that I wouldn't want to just throw it on an unsuspecting admin. There may be performance implications as well, and the existing code is very much tuned to MyISAM. Believe it or not, the patch applies to 2.16 unmodified. :)
Target Milestone: --- → Bugzilla 2.16
OK, I just looked at the ISAM->MyISAM conversion stuff myself, and it does explicitly look for ISAM and not just anything not MyISAM, so there's no conflict there. This is good to go.
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 184.108.40.206; previous revision: 220.127.116.11 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.289.2.9; previous revision: 1.289.2.8 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.309; previous revision: 1.308 done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.