263332 - Filepicker filter proc doesn't work correctly

Status: NEW

(Core :: XUL, defect)

Description

[jhp (no longer active)]

Off shoot from bug 225574.  The filepicker filter procedure
(FileDialogFilterProc) always returns true.

Comment 1

[jhp (no longer active)]

Attachment: first patch

So this patch makes it work on my system (10.3).  Haven't tried any of the
earlier ones.  It now follows the given extensions and only sets those files. 
Plus, if you are choosing an application, it only lets you choose an
application.

However, since this filter proc has been broken for quite some time, the users
have probably gotten accustomed to opening up any file they want in the
browser.  This patch would restrict the types of files that can be opened.  On
other OSes, this is remedied by having a drop down that lets you choose which
filters you wish to apply, so you can select the "Any file" filter if you
choose.

So, we have to decide which is better.	Filter the results, and put a filter
selection drop down in the "Open..." dialog, or just keep doing what we've been
doing, and let the user open any file they want.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.