Filepicker filter proc doesn't work correctly

NEW

Status

()

Core
XUL
14 years ago
8 years ago

People

(Reporter: jhp (no longer active), Assigned: jhp (no longer active))

Tracking

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Off shoot from bug 225574.  The filepicker filter procedure
(FileDialogFilterProc) always returns true.
(Assignee)

Comment 1

14 years ago
Created attachment 161378 [details] [diff] [review]
first patch

So this patch makes it work on my system (10.3).  Haven't tried any of the
earlier ones.  It now follows the given extensions and only sets those files. 
Plus, if you are choosing an application, it only lets you choose an
application.

However, since this filter proc has been broken for quite some time, the users
have probably gotten accustomed to opening up any file they want in the
browser.  This patch would restrict the types of files that can be opened.  On
other OSes, this is remedied by having a drop down that lets you choose which
filters you wish to apply, so you can select the "Any file" filter if you
choose.

So, we have to decide which is better.	Filter the results, and put a filter
selection drop down in the "Open..." dialog, or just keep doing what we've been
doing, and let the user open any file they want.
You need to log in before you can comment on or make changes to this bug.