Closed Bug 263340 Opened 20 years ago Closed 18 years ago

checksetup.pl should ask for 'urlbase' when set to the default value

Categories

(Bugzilla :: Installation & Upgrading, defect)

Product:
Bugzilla
Component:
Installation & Upgrading
Version:
2.19
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: goobix, Unassigned)

References

Details

Autoset URLBase by using Javascript and document.location, so the maintainer no longer has to copy-paste it. Could be set to be something optional.
hmm, I like this idea. I'll keep it in mind when I finish up the editparams rewrite.
Blocks: 46296
or use $cgi->self_url() we can probably guess the default maintainer as well, as the first person to hit editparams is most probably the maintainer.
Another thought... test maintainer and urlbase for the default values any time someone hits Bugzilla, and throw an error if the user doesn't have admin privs and they haven't been set yet. If the user does have admin privs, put a [% message %] block at the top of every page informing them that it hasn't been set yet with a link to editparams.
Severity: normal → enhancement
Priority: -- → P4
*** Bug 304936 has been marked as a duplicate of this bug. ***
No longer blocks: 46296
Depends on: 46296
LpSolit ended up finishing up the params rewrite, and this didn't get done with it.
Assignee: justdave → administration
QA Contact: mattyt-bugzilla → default-qa
(In reply to comment #5) > LpSolit ended up finishing up the params rewrite, and this didn't get done with > it. > myk suggested something better IMO, see bug 328108 comment 14. When running checksetup.pl, if the default URLbase is set, then it should ask to enter a valid one, and checksetup.pl should refuse to continue as long as the maintainer doesn't enter a valid URL. This is better than justdave's suggestion in comment 3 here as we avoid doing a check everytime someone hits Bugzilla. vladd, is this solution OK for you? We could morphe the bug summary to reflect that if you agree, else I can open another bug.
Looks good to me.
Due to the fix we used in bug 328108 (empty URLbase by default), I think it's not an enhancement anymore, but a requirement.
Assignee: administration → installation
Severity: enhancement → normal
Component: Administration → Installation & Upgrading
Flags: blocking2.22?
Flags: blocking2.20.2?
Priority: P4 → --
Summary: Autoset URLBase → checksetup.pl should ask for 'urlbase' when set to the default value
Target Milestone: --- → Bugzilla 2.20
I'm not going to change the requirements for the "answers" file on a stable branch, but it's a good idea for 2.22.
Flags: blocking2.22?
Flags: blocking2.22+
Flags: blocking2.20.2?
Flags: blocking2.20.2-
Okay, I think IRC meeting consensus is that this is not a significant-enough blocker to stop release of 2.22.
Flags: blocking2.22+ → blocking2.22-
Per comment 9.
Target Milestone: Bugzilla 2.20 → Bugzilla 2.22
Dupe of the initial installation page bug?
vladd, do you agree to WONTFIX this bug in favor of the Welcome page introduced in bug 349361?
It looks like we haven't heard from vladd, but I agree to WONTFIX it. Otherwise the welcome page would never show up.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
Target Milestone: Bugzilla 2.22 → ---
You need to log in before you can comment on or make changes to this bug.