263429 - execute() doesn't work on Mac OSX

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Johnny Stenback (:jst)]

It's impossible to write an xpi wrapper around a Mac installer today because
xpinstall's execute() call doesn't work on Mac OSX. The problem is that
nsProcessCommon in xpcom/threads uses nspr's PR_CreateProcess() etc which don't
work on the mac either. They'd work for creating processes for posix-like
executables (most likely), but not for executing Mac applications.

Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Make nsProcessCommon::Run() work on Mac OSX

Comment 2

[Johnny Stenback (:jst)]

This patch basically copies the app launching logic from nsProcessMac.cpp (no
longer part of the build, and thus now being removed from the tree) into
nsProcessCommon.cpp.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 161446 [details] [diff] [review]
Make nsProcessCommon::Run() work on Mac OSX

>Index: xpcom/threads/nsProcessCommon.cpp
>===================================================================

>+#elif defined(XP_MACOSX)
>+    LaunchParamBlockRec	launchPB;

Ugh, tabs.

>+    FSSpec resolvedSpec;
>+    OSErr err = noErr;
>+
>+    nsCOMPtr<nsILocalFileMac> macExecutable = do_QueryInterface(mExecutable);
>+    macExecutable->GetFSSpec(&resolvedSpec);
>+

Declare launchPB here.

>+    launchPB.launchAppSpec = &resolvedSpec;


>+    if (blocking && err == noErr) {
>+        while (1) {
>+            ProcessInfoRec info;
>+            info.processInfoLength = sizeof(ProcessInfoRec);
>+            info.processName = nil;
>+            info.processAppSpec = nil;

Use NULL for consistency.

Comment 4

[Johnny Stenback (:jst)]

Fixed locally.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 161446 [details] [diff] [review]
Make nsProcessCommon::Run() work on Mac OSX

sr=dveditz

Comment 6

[chris hofmann]

Comment on attachment 161446 [details] [diff] [review]
Make nsProcessCommon::Run() work on Mac OSX

a=chofmann for the branches

Comment 7

[Johnny Stenback (:jst)]

Fixed on trunk and branches.

Comment 8

[Boris Zbarsky [:bzbarsky]]

This caused bug 267269 (passing arguments to nsIProcess no longer works).

Comment 9

[Boris Zbarsky [:bzbarsky]]

Though I guess before it just silently didn't pass the args, while now it
throws, eh?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Though bug 267269 claims that the new process got the args somehow...