Closed Bug 263460 Opened 21 years ago Closed 21 years ago

OJI build failure using GCC 3.4.2

Categories

(Core Graveyard :: Java: OJI, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: caillon, Assigned: caillon)

References

()

Details

(Keywords: fixed-aviary1.0, fixed1.7.5, Whiteboard: fixed1.4.x)

Attachments

(1 file)

Attached patch PatchSplinter Review
GetSecureEnv() is declared as a static global http://lxr.mozilla.org/mozilla/source/modules/oji/public/ProxyJNI.h#67 and is implemented later on to do the same thing this is trying to do. http://lxr.mozilla.org/mozilla/source/modules/oji/src/ProxyJNI.cpp#1761 Remove the ambiguities by removing the spurious static function in the class.
Assignee: kyle.yuan → caillon
Status: NEW → ASSIGNED
Attachment #161461 - Flags: superreview?(brendan)
Attachment #161461 - Flags: review?(kyle.yuan)
Comment on attachment 161461 [details] [diff] [review] Patch Presumptive sr=me, before r= -- looks like the right thing. /be
Attachment #161461 - Flags: superreview?(brendan) → superreview+
Attachment #161461 - Flags: review?(kyle.yuan) → review+
Attachment #161461 - Flags: approval1.7.x?
Attachment #161461 - Flags: approval-aviary?
Comment on attachment 161461 [details] [diff] [review] Patch a=mkaply for branches
Attachment #161461 - Flags: approval1.7.x?
Attachment #161461 - Flags: approval1.7.x+
Attachment #161461 - Flags: approval-aviary?
Attachment #161461 - Flags: approval-aviary+
Checked in on trunk and all branches.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: fixed1.4.x
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: