OJI build failure using GCC 3.4.2

RESOLVED FIXED

Status

Core Graveyard
Java: OJI
RESOLVED FIXED
14 years ago
8 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

({fixed-aviary1.0, fixed1.7.5})

Trunk
x86
Linux
fixed-aviary1.0, fixed1.7.5

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed1.4.x, URL)

Attachments

(1 attachment)

Created attachment 161461 [details] [diff] [review]
Patch

GetSecureEnv() is declared as a static global
http://lxr.mozilla.org/mozilla/source/modules/oji/public/ProxyJNI.h#67

and is implemented later on to do the same thing this is trying to do.
http://lxr.mozilla.org/mozilla/source/modules/oji/src/ProxyJNI.cpp#1761

Remove the ambiguities by removing the spurious static function in the class.
Assignee: kyle.yuan → caillon
Status: NEW → ASSIGNED
Attachment #161461 - Flags: superreview?(brendan)
Attachment #161461 - Flags: review?(kyle.yuan)
Comment on attachment 161461 [details] [diff] [review]
Patch

Presumptive sr=me, before r= -- looks like the right thing.

/be
Attachment #161461 - Flags: superreview?(brendan) → superreview+

Updated

14 years ago
Attachment #161461 - Flags: review?(kyle.yuan) → review+
Attachment #161461 - Flags: approval1.7.x?
Attachment #161461 - Flags: approval-aviary?

Comment 3

14 years ago
Comment on attachment 161461 [details] [diff] [review]
Patch

a=mkaply for branches
Attachment #161461 - Flags: approval1.7.x?
Attachment #161461 - Flags: approval1.7.x+
Attachment #161461 - Flags: approval-aviary?
Attachment #161461 - Flags: approval-aviary+
Checked in on trunk and all branches.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0, fixed1.7.x
Resolution: --- → FIXED
Whiteboard: fixed1.4.x

Updated

8 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.