263479 - Tasks in multiweek view aren't treated properly

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Citrus538]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040907 Mozilla Sunbird/0.2a

In multiweek view with the "Tasks in View" option enabled, it is impossible to
delete tasks selected from the calendar.  If you try to edit them from the
Calendar, the "Edit Event" dialog appears rather than "Edit Task".

Reproducible: Always
Steps to Reproduce:
1.  Go into multiweek view.
2.  Go into the "View" menu and make sure "Tasks in View" is enabled.
3.  Create new task which starts on a certain day.
4.  Go to that day in the calendar, right-click the task, and select "Delete
Selected Event" or "Edit Selected Event".

Actual Results:  
If you tried to delete it, nothing happens.  If you try to edit it, the wrong
dialog box appears.  

Expected Results:  
The task should be deleted, or the appropriate dialog box should appear.

Note that double-clicking a task in multi-week view will open the appropriate
dialog.

Comment 1

[Torsten]

Confirmed with Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a4) Gecko/20040907
Mozilla Sunbird/0.2a

Comment 2

[Joey Minta]

I can confirm this behavior in Sunbird 0.2 and Calendar 2005011112 (firefox). 
While double-clicking on a task in view does correctly edit the task, the
context menu (right-click) for the task is still set for events, and hence does
not work properly.  Also, the 'Edit' and 'Delete' buttons in the toolbar are not
able to handle a task.

Status: NEW

Can someone please update the summary to be a bit more specific?  Suggest
something like "Cannot edit/delete a task from in calendar view, context menu
broken"

Comment 3

[Joey Minta]

Attachment: also care about tasks

The majority of this bug was fixed by the switch to the switch to the new views (bug 297934).  This patch just removes an obsolete filter in onDeleteItem so that deleting a task that's being displayed in the multiweek/month view actually is reflected in the view.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 216371 [details] [diff] [review]
also care about tasks

r=mvl

Comment 5

[Joey Minta]

Patch checked in.