"Remember logon" dialog box should have "No" as default

RESOLVED FIXED

Status

()

Toolkit
Password Manager
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Ido Beeri, Assigned: Andrew Schultz)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1

When an inexperienced Firefox user enters a user name and password of some
website on someone else's computer, he sees a dialog box. But he's
inexperienced, therefor he just presses Enter again to get rid of it.

Little does he know, he just made the password manager remember his passowrd,
because the default button is "Yes".

The point is: we should have "No" as the defualt button when asking if you want
to remember the password, for the above security reason.

Here's a screenshot of the dialog box anyhow.

Reproducible: Always
Steps to Reproduce:
(Reporter)

Comment 1

13 years ago
Created attachment 161518 [details]
the Remember Password dialog box defualt state

Comment 2

13 years ago
Unless the code is forked, this is a dup of bug 121443.
Assignee: firefox → bryner
Component: General → Password Manager
QA Contact: firefox.general → davidpjames
(Assignee)

Comment 3

13 years ago
it is forked.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Version: unspecified → Trunk
(Assignee)

Comment 4

13 years ago
Created attachment 188118 [details] [diff] [review]
port from seamonkey
Assignee: bryner → ajschult
Status: NEW → ASSIGNED
Attachment #188118 - Flags: review?(bryner)
Summary: "Remember logon" dialog box should has "No" as default → "Remember logon" dialog box should have "No" as default
Attachment #188118 - Flags: review?(bryner) → review+
(Assignee)

Updated

13 years ago
Attachment #188118 - Flags: approval-aviary1.1a2?

Updated

13 years ago
Attachment #188118 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Checking in nsPasswordManager.cpp;
/cvsroot/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,v 
<--  nsPasswordManager.cpp
new revision: 1.62; previous revision: 1.61
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 6

13 years ago
Resolution is incorrect. Reopen this bug, please.

Steps to Reproduce:
1. Open any site with logging form
2. Fill the form and push ENTER
3. You'll see prompt window
a) DO NOT use mouse, use keyboard
b) choose ANY option (use tabulator)
c) push ENTER

Your password IS remembered.

Comment 7

13 years ago
comment 6 is right, password is saved if you just hit enter at the prompt. 
reopening.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050709
Firefox/1.0+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b3)
Gecko/20050709 SeaMonkey/1.0a Mnenhy/0.7.2.10005

This also happens in the preference..change a preference (like the homepage) and
than go down to cancel and focus this option and than press enter..

The preferences changes you made take effect
Component: Password Manager → Widget
Flags: review+
Product: Firefox → Core

Updated

13 years ago
Flags: blocking1.8b3?
(Assignee)

Comment 9

13 years ago
I filed bug 300227 for the behavior described in comment 6, which is apparently
not really related to this bug, which /is/ fixed.  With this fixed, the focus is
initially on the No button now instead of Yes, and hitting Space (instead of
Enter) will do what you expect.

sending back to password manager
Status: REOPENED → RESOLVED
Last Resolved: 13 years ago13 years ago
Component: Widget → Password Manager
Product: Core → Firefox
Resolution: --- → FIXED

Updated

13 years ago
Flags: blocking1.8b3?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.