User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1 When an inexperienced Firefox user enters a user name and password of some website on someone else's computer, he sees a dialog box. But he's inexperienced, therefor he just presses Enter again to get rid of it. Little does he know, he just made the password manager remember his passowrd, because the default button is "Yes". The point is: we should have "No" as the defualt button when asking if you want to remember the password, for the above security reason. Here's a screenshot of the dialog box anyhow. Reproducible: Always Steps to Reproduce:
Unless the code is forked, this is a dup of bug 121443.
it is forked.
Created attachment 188118 [details] [diff] [review] port from seamonkey
13 years ago
Checking in nsPasswordManager.cpp; /cvsroot/mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp,v <-- nsPasswordManager.cpp new revision: 1.62; previous revision: 1.61 done
Resolution is incorrect. Reopen this bug, please. Steps to Reproduce: 1. Open any site with logging form 2. Fill the form and push ENTER 3. You'll see prompt window a) DO NOT use mouse, use keyboard b) choose ANY option (use tabulator) c) push ENTER Your password IS remembered.
comment 6 is right, password is saved if you just hit enter at the prompt. reopening. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050709 Firefox/1.0+
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b3) Gecko/20050709 SeaMonkey/1.0a Mnenhy/0.7.2.10005 This also happens in the preference..change a preference (like the homepage) and than go down to cancel and focus this option and than press enter.. The preferences changes you made take effect
I filed bug 300227 for the behavior described in comment 6, which is apparently not really related to this bug, which /is/ fixed. With this fixed, the focus is initially on the No button now instead of Yes, and hitting Space (instead of Enter) will do what you expect. sending back to password manager