263684 - nsMsgCompose should use the IO Service to go from file -> uri

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#3433

3433       sigOutput.AppendLiteral("<img src=\"file:///");
3434            /* XXX pp This gives me 4 slashes on Unix, that's at least one to
3435               much. Better construct the URL with some service. */
3436       sigOutput.AppendWithConversion(testSpec);

this could use nsNetUtil.h's nice function NS_NewFileURI, and nsIURI::GetSpec.
Also, this code could use nsIFile::Exists, to eliminate one further use of
testSpec (an nsFileSpec)

sigFile should probably be a function-scoped variable.


(all this is in nsMsgCompose::ProcessSignature)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

actually, an even better way to go from nsIFile -> URL Spec is
NS_GetURLSpecFromFile, also part of nsNetUtil.h.

Comment 2

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.