263685 - getComputedStyle not working on -moz-outline-radius

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Aaron Leventhal]

(Spinoff from bug 24676)
Code needs to be edited in mozilla/content/html/style/src/nsComputedDOMStyle.cpp
to support computed style for -moz-outline-radius

Comment 1

[Aaron Leventhal]

Attachment: Support outline in computed style

With this patch the following code returns the correct thing:
document.defaultView.getComputedStyle(node,'').getPropertyValue("-moz-outline-radius-topleft"));


However, I cannot seem to get any of these lines to work:
node.outline = "solid 3px black";	   node.mozOutline = "solid 3px black";

node.outlineStyle = "solid";		   node.mozOutlineStyle = "solid"
node.outlineWidth = "3px";		   node.mozOutlineWidth = "3px";
node.outlineColor = "black";		   node.mozOutlineColor = "black";
node.outlineRadius = "2px";		   node.mozOutlineRadius = "2px";
etc.

P.S. When should we get rid of the -moz and just make it outline?

Comment 2

[Aaron Leventhal]

Actually changing the outline through node.style does work, but you have to
capitalize the M in Moz, e.g.:
node.MozOutline = "solid 3px black";

I was thrown off by that -- usualy JS properties start with a lowercase letter.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 161638 [details] [diff] [review]
Support outline in computed style

>+    switch (aSide) {
>+      case NS_SIDE_TOP:
>+        outline->mOutlineRadius.GetTop(coord);
>+        break;
>+      case NS_SIDE_BOTTOM:
>+        outline->mOutlineRadius.GetBottom(coord);
>+        break;
>+      case NS_SIDE_LEFT:
>+        outline->mOutlineRadius.GetLeft(coord);
>+        break;
>+      case NS_SIDE_RIGHT:
>+        outline->mOutlineRadius.GetRight(coord);
>+        break;
>+      default:
>+        NS_WARNING("double check the side");
>+        break;
>+    }

Change this to just be:

outline->mOutlineRadius.Get(aSide, coord);

and fix where you copied it from as well.  (nsComputedDOMStyle has too much
copy&pasted code.  It needs to use nsCSSPropList.h somehow.  It may be worth
filing a bug on that (probably on me).)

>+    // Don't impl _moz_outline / outline since it just returns null as per spec

Don't add this -- there's already a comment above explaining what "////" means,
and you're not adding this comment to all the other "////", which seems to
imply that it's different from them, which it isn't.

sr=dbaron with those changes

Comment 4

[Aaron Leventhal]

Comment on attachment 161638 [details] [diff] [review]
Support outline in computed style

Will post a new patch addressing David's comments if requested to do so.

Comment 5

[Aaron Leventhal]

Checking in nsComputedDOMStyle.cpp;
/cvsroot/mozilla/content/html/style/src/nsComputedDOMStyle.cpp,v  <-- 
nsComputedDOMStyle.cpp
new revision: 1.130; previous revision: 1.129
done
Checking in nsComputedDOMStyle.h;
/cvsroot/mozilla/content/html/style/src/nsComputedDOMStyle.h,v  <-- 
nsComputedDOMStyle.h
new revision: 1.23; previous revision: 1.22
done