263689 - invalid URL opens new window despite tabbing preferences

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dan M]

Firefox's Single Window mode implemented in bug 172962 misbehaves a bit when
asked to open an invalid URL. If new windows are preffed to open into tabs,
Firefox will open that tab, and then a new window as well. See the attached
testcase for details.

Comment 1

[Dan M]

Attachment: testcase

Comment 2

[Tracy Walker [:tracy]]

Nominating to make sure it doesn't slide under the radar, but I expect it to be
minused.  :-)

Comment 3

[chris hofmann]

dan, are you close to a patch?

Comment 4

[Dan M]

Attachment: split new-tab and load-URI to allow proper return on URI load error

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 162857 [details] [diff] [review]
split new-tab and load-URI to allow proper return on URI load error

Will this mess up the referrer for the page in the new tab or anything like
that?

Comment 6

[Dan M]

No. No worse than it already was.

Comment 7

[Dan M]

Attachment: get proper return on URI load error and initialize referrer

Same as previous patch, but sets up the referrer as well. Note characterSet is
already being picked up somewhere. I don't know by whom. Magical elves. But it
seems to be always correct in my testing.

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 162950 [details] [diff] [review]
get proper return on URI load error and initialize referrer

>--- dom/public/idl/base/nsIBrowserDOMWindow.idl	30 Sep 2004 14:20:43 -0000	1.1.2.1
>+++ dom/public/idl/base/nsIBrowserDOMWindow.idl	22 Oct 2004 01:01:13 -0000

Change the IID of this interface.  r=me with that change.

Comment 9

[chris hofmann]

ok, lets get this one on the branches

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 162950 [details] [diff] [review]
get proper return on URI load error and initialize referrer

a=asa for aviary checkin.

Comment 11

[Tracy Walker [:tracy]]

verified on windows firefox branch build 2004102607.  test cases no longer open
another window.

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 162857 [details] [diff] [review]
split new-tab and load-URI to allow proper return on URI load error

removing obsolete review request