Closed
Bug 263760
Opened 21 years ago
Closed 21 years ago
/leave doesn't work for Unicode (non-ASCII) channels
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)
Details
(Whiteboard: cz-patch)
Attachments
(1 file)
|
3.28 KB,
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
When trying to /leave a non-ASCII channel, either with the name specified (in
Unicode) or without, it fails - usually with the error:
Internal error dispatching command “leave”.
TypeError: e.channel has no properties @
<chrome://chatzilla/content/commands.js> 1802
There's two bugs in the code triggering this. Firstly is getChannel:
http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/irc.js#492
The typo on line 502 means it fails for Unicode/non-ASCII channel names.
The second is in cmdLeave itself:
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/commands.js#1767
The getChannel on line 1768 fails, and returns |null|, but then it heads off to
line 1789 and keels over.
|
Assignee | |
Comment 1•21 years ago
|
||
I've also fixed a little regression from bug 261696, but importantly this fixes
the /leave problem for Unicode/non-ASCII channel names.
|
|
Assignee | |
Updated•21 years ago
|
Whiteboard: cz-patch
|
|
Assignee | |
Updated•21 years ago
|
Attachment #161706 -
Flags: review?(rginda)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 161706 [details] [diff] [review]
Correct typo, handle getChannel failing
r=rginda
Attachment #161706 -
Flags: review?(rginda) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Product: Core → Other Applications
|
||
Updated•4 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•