Open
Bug 263839
Opened 20 years ago
Updated 2 years ago
'Save Link Target As' may automatically add .htm to the target save-as filename
Categories
(Firefox :: File Handling, defect)
Firefox
File Handling
Tracking
()
NEW
People
(Reporter: Time_lord, Unassigned)
References
Details
Attachments
(2 obsolete files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20041010 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20041010 With the checkin of the patch (attachment 160223 [details] [diff] [review]) for bug 160454, there is now no HEAD request done before saving a link target. Previously, the HEAD response was used (if possible) to determine the suggested target filename (when saving a url). However now, when the target is an http address such as the root note of a website (and not specifically an html page, file or otherwise), there is a problem. Without a known content type or document object, the browser can only /guess/ a sensible name for the target filename. For example, if the target URL is http://www.xyz.com, the target filename would be given the name "http_www.xyz.com_", which will be wrong in basically all cases. Therefore with patch 160223, the extension ".htm" is added to the suggested filename IF, at the end of the method that determines the filename, the following is true: a) a file extension has not yet been determined, b) the url starts with "http://", c) the content type is unknown, and d) there is no document object. NB (c) and (d) are true when performing a 'save link target'. This should cause no problem when linking to a website (apparently not specifically to a particular file) where the protocol is http, as it would be most common for the webserver to present an html file as the default file. While this default action (adding the ".htm" extension) should cause no problem in the majority of cases, can we come up with a better heuristic? Reproducible: Couldn't Reproduce Steps to Reproduce: Somebody should be able to confirm if there's a problem by making the default page served up by a web site something other than an html file. (Sorry, I cannot easily.)
(In reply to comment #0) > However now, when the target is an http address such as the root note of a barrggg, root note = root node ;-)
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
This small patch applies the same logic to https:// urls that was introduced by the patch for bug 160454.
Attachment #164833 -
Flags: review?(bzbarsky)
Comment 3•20 years ago
|
||
Comment on attachment 164833 [details] [diff] [review] Include also https in this approach r=bzbarsky, but this really isn't a patch for _this_ bug....
Attachment #164833 -
Flags: review?(bzbarsky) → review+
(In reply to comment #3) > (From update of attachment 164833 [details] [diff] [review]) > r=bzbarsky, but this really isn't a patch for _this_ bug.... > No, it isn't a patch to resolve the problem, but it is a patch nonetheless to make the code more consistent before a better alternative is found. Who should I ask for a SR?
Updated•20 years ago
|
Attachment #164833 -
Flags: superreview?(neil.parkwaycc.co.uk)
Comment 5•20 years ago
|
||
Comment on attachment 164833 [details] [diff] [review] Include also https in this approach Sorry, I'm not letting you get away with duplicating bad code, those aURL tests can all be handled by a fairly simple regexp.
Attachment #164833 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview-
As requested, using a much tidier regex
Attachment #164833 -
Attachment is obsolete: true
Attachment #165403 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #165403 -
Flags: review?(bzbarsky)
Comment 7•20 years ago
|
||
Comment on attachment 165403 [details] [diff] [review] Include also https in this strategy (using regex) You probably don't need quite so many brackets ;-)
Attachment #165403 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment 8•20 years ago
|
||
Comment on attachment 165403 [details] [diff] [review] Include also https in this strategy (using regex) r=bzbarsky
Attachment #165403 -
Flags: review?(bzbarsky) → review+
Comment 9•20 years ago
|
||
Comment on attachment 165403 [details] [diff] [review] Include also https in this strategy (using regex) I just checked this patch in.
Attachment #165403 -
Attachment is obsolete: true
Comment 10•20 years ago
|
||
Could this bug be resolved as FIXED?
Comment 11•20 years ago
|
||
See comment 3 and comment 4
Updated•15 years ago
|
Assignee: file-handling → nobody
QA Contact: ian → file-handling
Updated•8 years ago
|
Product: Core → Firefox
Version: Trunk → unspecified
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•