26404 - editor keybinding file fire command conflict with ALT+Num pad key

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Frank Tang]

refer to 25280 for the main problem. I file a new bug because that bug is
currently assign to hyatt for the general xul keybinding but we need mjudge to
change the keybinding for editor also.

I found the following xul file which have keybinding for the num pad '1'
(VK_END). Please change them so these command won't get fired when the ALT is down.


/xpfe/global/resources/content/inputBindings.xul, line 17 --
document.commandDispatcher.getControllerForCommand('cmd_endLine');
/xpfe/global/resources/content/inputBindings.xul, line 18 --
controller.doCommand('cmd_endLine');"/>
/xpfe/global/resources/content/editorBindings.xul, line 16 --
document.commandDispatcher.getControllerForCommand('cmd_endLine');
/xpfe/global/resources/content/editorBindings.xul, line 17 --
controller.doCommand('cmd_endLine');"/>
/xpfe/global/resources/content/textAreaBindings.xul, line 17 --
document.commandDispatcher.getControllerForCommand('cmd_endLine');
/xpfe/global/resources/content/textAreaBindings.xul, line 18 --

Comment 1

[David Hyatt]

This is easy, Mike.  Just add alt="false" to all of the end line bindings 
(browserBindings.xul, editorBindings.xul, platformHTMLBindings.xul, 
htmlBindings.xul).

While you're at it, you may as well patch Home, PageUp, and PageDown, since 
those will all have the same problem.  i guess maybe even Ins and Del will too?

Comment 2

[Frank Tang]

Please do that for those 9 keys in the num pad '0' (Ins) , '1' (end), '2' 
(down), '3' (PgDn) , '4' (left), '6' (right) , '7' (home), '8' (up), '9' (PgUp)

Comment 3

[rubydoo123]

Mike -- try and get this one cleaned up for M14

Comment 4

[mjudge]

fixed. hyatt and my change seem to have nailed this. also for shift and control 
key illegal combinations have been stopped.

Comment 5

[sujay]

verified in 2/14 build.