264068 - XTF needs some JS and CPP testcases

Status: RESOLVED WONTFIX

(Core Graveyard :: XTF, defect)

Description

[aaronr]

XTF needs some testcases to show developers how to use the technology.  Best to
have testcases that do the same thing, but written in JS AND CPP.

Comment 1

[aaronr]

I've got a JS and CPP testcase to contribute.  Building it against the trunk
right now to make sure it works outside of the xforms branch

Comment 2

[aaronr]

Attachment: proposed testcases

here are some testcases that could be included in the tree if they look ok to
you.  However, there is a crash if you run the .js testcase and click on the
SSN textfields instead of tabbing to them.  Is this something wrong with my
testcase or a bug that needs to be filed?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

One missing thing.

NS_IMETHODIMP
WidgetSSNElement::HandleDefault(nsIDOMEvent *aEvent, PRBool *aHandled)
{
  *aHandled = PR_FALSE;
  return NS_OK;
}

Comment 4

[Allan Beaufour]

Comment on attachment 162139 [details]
proposed testcases

Ahem, using the same CID as  the XForms lib. might not be a good idea :)

And two small changes, to remove the warnings:
diff ../../tests.orig/ssncpp/WidgetSSNElement.cpp ./WidgetSSNElement.cpp
518c518
<     if( fieldValue.Length() < iMaxLen )
---
>     if( fieldValue.Length() < (PRUint32) iMaxLen )
578c578,579
<   nsresult res = aChangeEvent->GetTarget( getter_AddRefs(target) );
---
>   nsresult rv = aChangeEvent->GetTarget( getter_AddRefs(target) );
>   NS_ENSURE_SUCCESS(rv, rv);

Comment 5

[Allan Beaufour]

Comment on attachment 162139 [details]
proposed testcases

BTW, remove the Windows CR + LF...

Comment 6

[aaronr]

Attachment: proposed testcases v2

incorporated the suggested changes

Comment 7

[aaronr]

Attachment: makefile changes to account for new testcases

attached patch to be used to properly build new testcases.

Comment 8

[Robert Marcano]

The ssncpp.xpt file is not installed neither generated, libssncpp.so is
installed ok on the components directory, so the CPP version does not works out
of the box. the JS vesion work ok

Comment 9

[aaronr]

Attachment: proposed testcases v3

fixed problem where BeginAddingChildren function missing from
WidgetSSNElement.cpp

Comment 10

[Robert Marcano]

attachment #166477 [details] solves the problem I was experiencing

Comment 11

[Alex Vincent [:WeirdAl]]

This is interesting (and very helpful!).  I've been meaning to write an article
on XTF anyway... would anyone object if I provided a SVG-based testcase as I
wrote it?

Comment 12

[Allan Beaufour]

This should be put on the wiki I think.

Comment 13

[Alex Vincent [:WeirdAl]]

I actually have just submitted a xpcshell testcase for bug 378247.  (When aaronr first put the testcases up, we didn't have the xpcshell-simple test harness.)  Maybe we can start to work on this bug a bit more.

Comment 14

[aaronr]

Attachment: xtf extension

This is similar to the testcases in v3 but written to go in a sample directory since it doesn't really fit into unit testcase harness.  It is an XTF extension that uses XBL to do the UI, similar to how XForms does it.  Building the directory will build a .xpi that can be installed.

Comment 15

[Ray Kiddy]

I am working on script that launch Firefox and automatically shut down the instance after some activity. For example, I can run a script which will:

- launch with one extension installed
- quit that instance
- launch with another extension installed
- quit that instance

Let me know if this might have some relevance to what you are trying to test here.

Comment 16

[Alex Vincent [:WeirdAl]]

XTF has been removed from the tree.

Comment 17

[Alex Vincent [:WeirdAl]]

[xtfisdead] for filtering purposes.