264146 - Form buttons not highlighted with full keyboard access (no focus ring)

Status: RESOLVED FIXED

(Camino Graveyard :: HTML Form Controls, defect, P3)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041012 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041012 Camino/0.8+

With OS X's full keyboard access enabled, Camino refuses to tab to (allow
focus/selection of) buttons in forms; all other form elements seem selectable. 
Safari allows selection of form buttons (only other Cocoa browser I have).

Reproducible: Always
Steps to Reproduce:
1.  Enable full keyboard access (Keyboard & Mouse system prefpane, Keyboard
Shortcuts section)

2.  Go the bugzilla login page referenced in URL field above

3.  Tab through the form elements (fields/checkbox) 

Actual Results:  
No focus ring on the login button to allow form submission via full keyboard
access (space bar "performs" the highlighted button if it is not the default
button in a form, dialogue, etc.)

Expected Results:  
Tabbing through the elements should have put a focus ring around the login
button and allowed the form to be submitted via space bar as per OS X full
keyboard access.

See Help Viewer article "Full Keyboard Access shortcuts for selecting an action"
for explanation of the shortcuts involved.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Sorry, I didn't test thoroughly enough on this one.  The form buttons are being
tabbed to (and are thus selectable); the focus ring is just not being displayed
when one has tabbed to the button.

I will change the Summary to "Form buttons not highlighted with full keyboard
access (no focus ring)" if I have that privilige.

Comment 2

[Mike Pinkerton (not reading bugmail)]

i think we already have a dupe of this

Comment 3

[Mike Pinkerton (not reading bugmail)]

oh, not making a focus ring is a conscious choice because there is a bug in OSX
that causes them to draw incorrectly in a quickdraw view when they have focus.

i would bet the bug still exists, it definately does on jaguar.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mike, is the OS X bug you're talking about the same one that causes bug 209649?
 (That's the only similar Camino bug I found before filing this one.)  

If so, I'm not noticing any bad erasures of focus rings on radio
buttons/checkboxes with my current setup (0041012 Camino/0.8+, OS X 10.3.5)

Comment 5

[Mike Pinkerton (not reading bugmail)]

the OS bug is only on pushbuttons, which is why we turned it off just for that.
there's a bug for it around here somewhere, i'm sure. Maybe not.

Comment 6

[sairuh (rarely reading bugmail)]

I think the supressing was mentioned in bug 197335 comment 13 and 14, as part of
the fix in bug 197094.

Comment 7

[Simon Fraser [no longer active]]

Fixed on Tiger, right?

Comment 8

[Samuel Sidler (old account; do not CC)]

I believe that yes, this is fixed in Tiger. I see a focus ring when tabbing
through form widgets.

Comment 9

[Mike Pinkerton (not reading bugmail)]

this works on tiger which is the only place we felt comfortable turning on the
focus rings for buttons. 

Comment 10

[jonathan chetwynd]

could the whole button change colour to show it has focus?

note many applications use this to show which button is the default, for instance in don't save, cancel, save, "save" might be a pulsing blue button.

otherwise it seems that tbe blue border is masked by blue backgrounds, which would therefore be forbidden.

Comment 11

[Stuart Morgan]

(In reply to comment #10)
> could the whole button change colour to show it has focus?
> 
> note many applications use this to show which button is the default

No. "Default" and "focused" are entirely different concepts. Using anything other than the system-wide method for showing focus would be inconsistent and confusing, even within Camino itself (chrome vs. content).