Closed
Bug 264309
Opened 22 years ago
Closed 22 years ago
Consolidate CloneNode implementation macros
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha5
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(2 files)
|
52.79 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
|
3.42 KB,
patch
|
peterv
:
superreview-
|
Details | Diff | Splinter Review |
Patch coming up
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.8alpha5
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #162051 -
Flags: superreview?(jst)
Attachment #162051 -
Flags: review?(jst)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 162051 [details] [diff] [review]
v1
r+sr=jst
Attachment #162051 -
Flags: superreview?(jst)
Attachment #162051 -
Flags: superreview+
Attachment #162051 -
Flags: review?(jst)
Attachment #162051 -
Flags: review+
|
|
Assignee | |
Updated•22 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 3•22 years ago
|
||
|
|
||
Updated•22 years ago
|
Attachment #162333 -
Flags: superreview?(peterv)
Attachment #162333 -
Flags: review?(jst)
|
|
Assignee | |
Comment 4•22 years ago
|
||
Comment on attachment 162333 [details] [diff] [review]
nsRefPtr anyone?
That doesn't compile afaik. aResult is a nsIDOMNode*, swap doesn't work with
base class pointers.
Attachment #162333 -
Flags: superreview?(peterv) → superreview-
|
|
||
Comment 5•22 years ago
|
||
Comment on attachment 162333 [details] [diff] [review]
nsRefPtr anyone?
My apologies, I must have run make from the wrong folder :-[
Attachment #162333 -
Flags: review?(jst)
You need to log in
before you can comment on or make changes to this bug.
Description
•