264326 - current mozilla/firefox/thunderbird does not work reliable on s390(x)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041013
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041013

mozilla is very unstable on s390(x) at the moment (1.7.x) and firefox/thunderbird
get segmentation faults when trying to call "* -register".

According to our s390 developers the attached patch fixes wrong stubs and a
miscompilation because of wrong inlining.

Reproducible: Always
Steps to Reproduce:
.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: xpcom fixes for s390(x)

Comment 2

[Jean-Marc Desperrier]

Marking new and adding the person involved in bug 90010 as a CC

Comment 3

[Jean-Marc Desperrier]

bug 90010 was assigned to blizzard, but as you provide a patch and ask blizzard
to review it, I'm assigning this one to you and I put [e-mail] in
the CC list.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Mike, you already saw a part of the patch in our source RPM.
We had to extend the patch to actually build firefox and thunderbird on s390(x)
on our current distributions. Just to keep you informed and maybe you would like
to sr

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 162060 [details] [diff] [review]
xpcom fixes for s390(x)

Yeah, looks safe enough, and if you're running with it on s390, who am I to
argue?

Let's get it on the stable/release branches too.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 162060 [details] [diff] [review]
xpcom fixes for s390(x)

a=asa

Comment 7

[Kenneth Herron]

Checked in on trunk:

cvs commit: Examining .
Checking in xptcinvoke_linux_s390.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_s390.cpp,v 
<--  xptcinvoke_linux_s390.cpp
new revision: 1.3; previous revision: 1.2
done
Checking in xptcinvoke_linux_s390x.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_s390x.cpp,v
 <--  xptcinvoke_linux_s390x.cpp
new revision: 1.3; previous revision: 1.2
done
Checking in xptcstubs_linux_s390.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_linux_s390.cpp,v 
<--  xptcstubs_linux_s390.cpp
new revision: 1.3; previous revision: 1.2
done
Checking in xptcstubs_linux_s390x.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_linux_s390x.cpp,v 
<--  xptcstubs_linux_s390x.cpp
new revision: 1.3; previous revision: 1.2
done

Comment 8

[Kenneth Herron]

Checked in on MOZILLA_1_7_BRANCH:

Checking in xptcinvoke_linux_s390.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_s390.cpp,v 
<--  xptcinvoke_linux_s390.cpp
new revision: 1.1.50.1; previous revision: 1.1
done
Checking in xptcinvoke_linux_s390x.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_s390x.cpp,v
 <--  xptcinvoke_linux_s390x.cpp
new revision: 1.1.50.1; previous revision: 1.1
done
Checking in xptcstubs_linux_s390.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_linux_s390.cpp,v 
<--  xptcstubs_linux_s390.cpp
new revision: 1.1.50.1; previous revision: 1.1
done
Checking in xptcstubs_linux_s390x.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_linux_s390x.cpp,v 
<--  xptcstubs_linux_s390x.cpp
new revision: 1.1.50.1; previous revision: 1.1
done

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

fixed on trunk and 1_7_BRANCH. (thanks Kenneth)
aviary is missing because of its RC state.