26452 - linux, mac: bring up context menu, another flashes in upper-left of browser

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[sairuh (rarely reading bugmail)]

i saw this on comm bits for mac [2000020215] and linux [2000020209], but not on
the non-comm bits for winNT [2000020215]. dunno how much a diff that makes...

anyhow, to repro is easy --bring up a context menu anywhere on a webpage (text,
links, images, framed or non-framed content). you'll notice that another context
menu will briefly flash in the upper-left of the browser window.

Comment 1

[sairuh (rarely reading bugmail)]

added pp keyword since i've seen it only on mac and linux, so far... and it's
also a regression.

Comment 2

[sairuh (rarely reading bugmail)]

ugh, forgot to add: methinks this is a separate issue from bug 23026, since
that's specific to context menus over textareas.

Comment 3

[Mike Pinkerton (not reading bugmail)]

this is happening because of this flow of events:

- style system says the view should be visible (but it's still 0,0)
- reflow resizes the frame (real size, but now visible and in upper left)
- finishing reflow in popup code moves to correct location

The problem is that the style system makes the view visible before we move/resize 
it to the right place. hyatt? any ideas? you understand this flow pretty well.

Comment 4

[Mike Pinkerton (not reading bugmail)]

i'd like to have this fixed for m14

Comment 5

[Stuart Parmenter]

yes, seeing this over and over makes me nauseous

Comment 6

[David Hyatt]

Path to fix:

(1) Change the style rules in xul.css that make menus visible in response to the 
open attribute to use a new attribute, e.g., menucomplete.

(2) Just before showing the view in syncviewwithframe, make a call to a new 
method, MarkAsComplete.

(3) Copy the code from MarkAsGenerated and do the same thing, but with a 
menucomplete attribute instead of a menugenerated attribute.

(4) When a menu closes, the menucomplete attribute must be removed.  This can be 
done by patching the OpenMenu method (using the close case).

Comment 7

[Mike Pinkerton (not reading bugmail)]

thanks for the summary, hyatt. our discussion this morning was before food so i 
was a little lightheaded ;)

Comment 8

[Mike Pinkerton (not reading bugmail)]

fixed.

Comment 9

[sairuh (rarely reading bugmail)]

verif on mac and linux using today's comm bits [2000-02-10-08].