264656 - Find Next and Previous clears "Phrase not found"

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

When searching a non-found phrase the toolbar shows the "Phrase not found" text
and icon, using "Find Previous" and "Find Next" button or keyboard shortcut
clears that text and icon even when the phrase isn't found.

Reproducible: Always
Steps to Reproduce:
1. Press CRTL-F
2. Enter a non excisting phrase
3. Watch the "Phrase not found" appearing
3. Press "Find Next" or "Find Next" (or their keyboard shortcuts)

Actual Results:  
"Phrase not found" disappeares.

Expected Results:  
Should display "Phrase not found".

If the find toolbar is closed the find-next/previous keyboard shortcuts open the
find toolbar, but doesn't show the "Phrase not found" text and icon if the
phrase isn't found.

Comment 1

[Nickolay_Ponomarev]

confirmed
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041016 Firefox/1.0

Comment 2

[Nickolay_Ponomarev]

looks like it is a regression, someone on IRC said it doesn't happen with 20041015.

Comment 3

[Blake Ross]

Should be fixed now.

Comment 4

[Michael Clackler]

(In reply to comment #3)
> Should be fixed now.

Blake,

This is not yet fixed.  When using the keyboard shortcuts with a hidden findbar
and a not-found string, when the bar is opened the not-found status is cleared.
 We need to updateStatus after opening the findbar in this case.

Patch to come.

Comment 5

[Michael Clackler]

Attachment: patch to fix

Updates Status after opening the findbar with ctrl-g or shift-ctrl-g with a
not-found string in order to display "not found" status that was cleared when
bar was opened

Comment 6

[Blake Ross]

I forgot about that case. Thanks Mike.