Clicking on fallback image starts drag because of plugin finder service

RESOLVED FIXED

Status

Toolkit Graveyard
Plugin Finder Service
P2
major
RESOLVED FIXED
14 years ago
4 years ago

People

(Reporter: bz, Assigned: jst)

Tracking

({fixed-aviary1.0, fixed1.7.5, regression})

1.7 Branch
fixed-aviary1.0, fixed1.7.5, regression
Bug Flags:
blocking-aviary1.0 +

Details

(Whiteboard: [HAVE FIX], URL)

Attachments

(1 attachment, 1 obsolete attachment)

BUILD: Current branch Firefox nightly

STEPS TO REPRODUCE:
1)  Load the URL in the "URL" field
2)  Click on the image
3)  Wait for plugin finder service dialog to tell you there are no suitable
    plugins
4)  Click Finish in the dialog

EXPECTED RESULTS:  Dialog goes away and the link is followed.

ACTUAL RESULTS:  Dialog goes away and the cursor looks like a drag cursor. 
Clicking somewhere performs a drop of the image at that point.  It's impossible
to follow the link.

NOTE:  Actually trying to drag the image instead of just clicking _still_ gives
       this popup dialog.

The mishandling of fallback content is a pretty serious regression in <object>
handling over SeaMonkey...
(Assignee)

Comment 1

14 years ago
Created attachment 162799 [details] [diff] [review]
Deal with click events and not with mousedown events, and prevent default in the right places.
(Assignee)

Updated

14 years ago
Attachment #162799 - Flags: superreview?(bzbarsky)
Attachment #162799 - Flags: review?(doronr)
(Assignee)

Comment 2

14 years ago
Created attachment 162801 [details] [diff] [review]
Let object-tags deal with their own events, only regsiter click events on non-object tags.
(Assignee)

Updated

14 years ago
Attachment #162799 - Attachment is obsolete: true
Attachment #162799 - Flags: superreview?(bzbarsky)
Attachment #162799 - Flags: review?(doronr)
(Assignee)

Updated

14 years ago
Attachment #162801 - Flags: superreview?(bzbarsky)
Attachment #162801 - Flags: review?(doronr)
Comment on attachment 162801 [details] [diff] [review]
Let object-tags deal with their own events, only regsiter click events on non-object tags.

sr=bzbarsky
Attachment #162801 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Flags: blocking-aviary1.0?
Keywords: regression
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Whiteboard: [HAVE FIX]

Updated

14 years ago
Attachment #162801 - Flags: review?(doronr) → review+
(Assignee)

Updated

14 years ago
Attachment #162801 - Flags: approval-aviary?

Updated

14 years ago
Flags: blocking-aviary1.0? → blocking-aviary1.0+

Comment 4

14 years ago
Comment on attachment 162801 [details] [diff] [review]
Let object-tags deal with their own events, only regsiter click events on non-object tags.

a=asa for aviary checkin.
Attachment #162801 - Flags: approval-aviary? → approval-aviary+
(Assignee)

Comment 5

14 years ago
Fixed on aviary branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Keywords: fixed1.7.5
Product: Firefox → Toolkit
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.