264679 - Clicking on fallback image starts drag because of plugin finder service

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current branch Firefox nightly

STEPS TO REPRODUCE:
1)  Load the URL in the "URL" field
2)  Click on the image
3)  Wait for plugin finder service dialog to tell you there are no suitable
    plugins
4)  Click Finish in the dialog

EXPECTED RESULTS:  Dialog goes away and the link is followed.

ACTUAL RESULTS:  Dialog goes away and the cursor looks like a drag cursor. 
Clicking somewhere performs a drop of the image at that point.  It's impossible
to follow the link.

NOTE:  Actually trying to drag the image instead of just clicking _still_ gives
       this popup dialog.

The mishandling of fallback content is a pretty serious regression in <object>
handling over SeaMonkey...

Comment 1

[Johnny Stenback (:jst)]

Attachment: Deal with click events and not with mousedown events, and prevent default in the right places.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Let object-tags deal with their own events, only regsiter click events on non-object tags.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162801 [details] [diff] [review]
Let object-tags deal with their own events, only regsiter click events on non-object tags.

sr=bzbarsky

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 162801 [details] [diff] [review]
Let object-tags deal with their own events, only regsiter click events on non-object tags.

a=asa for aviary checkin.

Comment 5

[Johnny Stenback (:jst)]

Fixed on aviary branch.