Closed
Bug 264693
Opened 20 years ago
Closed 20 years ago
Update replicated file picker logic
Categories
(Firefox :: File Handling, defect)
Firefox
File Handling
Tracking
()
RESOLVED
DUPLICATE
of bug 231048
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file, 2 obsolete files)
|
4.89 KB,
patch
|
Details | Diff | Splinter Review |
contentAreaUtils.js, nsHelperAppDlg.js and nsHelperAppDlg.js.in have to
replicate the file pickers logic and Neil has suggested a cleaner way of doing it.
var parts;
while (aLocalFile.exists()) {
parts = /(-\d+)?(\.[^.]+)?$/.test(aLocalFile.leafName);
aLocaleFile.leafName = RegExp.leftContext + (RegExp.$1 - 1) + RegExp.$2;
}
Attachment #162331 -
Flags: review?(bugs)
Attachment #162331 -
Flags: review?(bugs)
Only difference is removal of "var parts;" which is not required.
Attachment #162331 -
Attachment is obsolete: true
Attachment #163481 -
Flags: review?(vladimir)
Attachment #163481 -
Flags: review?(vladimir)
Changes since last patch: * Removed patch to nsHelperAppDlg.js as that file has gone from the tree * Moved filepicker logic into separate function as per suite version of contentAreaUtils.js
Attachment #163481 -
Attachment is obsolete: true
Attachment #170159 -
Flags: review?(vladimir)
Attachment #170159 -
Attachment description: Unbitrotted version of tweaked patch → Unbitrotted version of tweaked patch v0.1b
Attachment #170159 -
Flags: review?(vladimir)
*** This bug has been marked as a duplicate of 231048 ***
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•