264713 - ensure nsExternalAppHandler have a reference to the helperappservice

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

they should addref sSrv in the ctor and ->Release it in the dtor.

this might be related to some of the crashes from the following url, although I
find this somewhat doubtful.

http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=movefile&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162342 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.273; previous revision: 1.272
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 162342 [details] [diff] [review]
patch

this is a safety measure to avoid potential shutdown crashes when downloads are
in progress. very low risk. would be good to have on the branches.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 162342 [details] [diff] [review]
patch

a=asa for aviary and 1.7 checkin.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

aviary branch:
cvs commit: Examining uriloader/exthandler
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.253.2.1.2.4; previous revision: 1.253.2.1.2.3
done

1.7 branch:
Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.253.2.5; previous revision: 1.253.2.4
done