264882 - (XiHashed) View Source turns Ξ to &#Xi;

Status: RESOLVED FIXED

(Core Graveyard :: View Source, defect)

Description

[Robin Lionheart]

Whew viewing the source of an XHTML page in Firefox 1.0PR1, Ξ and ξ
entities in the source are converted to &#Xi; and &#xi; in the View Source window.

Comment 1

[Ross Shannon]

Confirmed. Strange, even in a listing with other entities, like
http://www.degraeve.com/reference/specialcharacters.php, only Ξ and ξ get
the hash sign added.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

It looks like the code that outputs view-source entities is outdated (like we
didn't used to consume the # on hex entities, so we guessed). We now *do* do
this. I'll attach a patch, but I need bug 263083 to be checked in first.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Don't prepend a # for no apparent reason.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Maybe I'm missing something, but shouldn't that
!theStr.LowerCaseEqualsLiteral("xi") check ensure that we don't muck with ξ?

What's the value of theStr coming throught this code for:

"ξ", "e", "A" ?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: testcase

These are some edge cases. Basically this is bz's list... View the source to
test.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 162594 [details] [diff] [review]
patch v1

r+sr=bzbarsky if you just pass through GetStringValue() without assigning into
theStr (I think that should be safe, but check).

Comment 7

[Robin Lionheart]

Special casing "xi" is the wrong way to go. 

This bug also affects MathML named entities beginning with "x" -- and it would
be ludicrous to also special case xwedge, xvee, xnis, xcap, xcup, xnis, xutri,
xdtri, xlarr, xrarr, xharr, xlArr, xrArr, xhArr, xmap, xodot, xoplus, xotime,
xuplus, xsqcup, Xscr, xscr, Xfr, xfr, Xopf, and xopf.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Robin, did you actually read the patch?

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch for checkin

For reference, this is the patch that will be checked in once the tree reopens.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.