265039 - Middle-clicking history items no longer opens them in new tabs

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

10/18 aviary build.

Steps to reproduce:
1. Open the history sidebar.
2. Middle-click an item.

Result: the item becomes selected, but nothing else happens.
Expected: item should open in a new tab.

The checkin that broke this was at 2004-10-17 18:15.  The intent of the checkin
seemed to be to make Ctrl and Shift do multiple selection actions like in a
normal listboxes.

Comment 1

[Steve England [:stevee]]

confirming win2k sp4
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041019 Firefox/1.0

Comment 2

[chris hofmann]

ben is having a look...

Comment 3

[Bill Gianopoulos [:WG9s]]

Ctrl-clicking in history has always opened in new tab and this is now broken. 
We kind of can't have crtl click be doing 2 things here.  Need to decide which
crtl-click action is the correct one and document it that way.

Comment 4

[Bill Gianopoulos [:WG9s]]

Actually, the way it works now is completely inconsistant with a normal picker
window where shift-click and ctrl-click can select multiple items.  In a picker
of this sort then single click would need to select a single item.  So, either
need to revert to requiring a double click to open a page from bookmarks and
history to make it work like a picker, or have it work like links on a webpage
and have ctrl-click open in tabs etc.  The current behaviour is not constant
with either interface.

Comment 5

[Steve England [:stevee]]

this bug now appears to be fixed (although how I don't know)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041020 Firefox/1.0

Comment 6

[Bill Gianopoulos [:WG9s]]

This was fixed by the checkin for bug 265150.

Comment 7

[Asa Dotzler [:asa]]

resolving as Fixed per previous two comments.