265109 - Use different character encoding for different platforms for README.txt

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Vincent Béron]

Use the same character encoding for README.txt as the installer, as different
platforms are better suited with different character encodings.

The version in CVS will always be in UTF-8.

Basically, I plan to include charset.mk in the browser/locales/Makefile and then
use iconv to convert from UTF-8 to the specific codepage used on Windows for
that language, to get a README.txt well encoded for each platform.

Comment 1

[Vincent Béron]

Attachment: Use different encoding for README.txt based on platform used

This should fix it.

Comment 2

[Vincent Béron]

Comment on attachment 162592 [details] [diff] [review]
Use different encoding for README.txt based on platform used

Requesting review and approval-aviary.

Comment 3

[Benjamin Smedberg]

Comment on attachment 162592 [details] [diff] [review]
Use different encoding for README.txt based on platform used

Please rename README_FILES to README_FILE

>+include $(topsrcdir)/toolkit/locales/$(AB_CD)/installer/windows/charset.mk

We should only include this file if we're on the win32 case, and we should only
call iconv on non-en-US win32, so something like this:

> libs:: $(addprefix $(AB_CD)/,$(README_FILES))
>-	$(INSTALL) $^ $(DIST)/bin
>+	iconv -f UTF-8 -t $(README_CHARSET) $^ > $(DIST)/bin/$(README_FILES)

if

> 
> libs realchrome:: $(addprefix $(AB_CD)/profile/,$(PROFILE_FILES))
> 	$(INSTALL) $^ $(DIST)/bin/defaults/profile
> 
> libs realchrome:: $(addprefix $(AB_CD)/profile/chrome/,$(PROFILE_CHROME))
> 	$(INSTALL) $^ $(DIST)/bin/defaults/profile/chrome
> 
> install:: $(addprefix $(AB_CD)/profile/,$(PROFILE_FILES))

Comment 4

[Vincent Béron]

Attachment: Use different encoding for README.txt based on platform used, take 2

Comment 5

[Vincent Béron]

Comment on attachment 162596 [details] [diff] [review]
Use different encoding for README.txt based on platform used, take 2

README_FILES will likely contain the license file in the near future.
Adresses issues discussed on IRC.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 162596 [details] [diff] [review]
Use different encoding for README.txt based on platform used, take 2

a=asa for aviary checkin.

Comment 7

[Benjamin Smedberg]

Fixed on branch, doesn't apply to trunk yet

Comment 8

[Alexander L. Slovesnik]

I still see README.txt in UTF-8 on Windows.
Windows XP SP2.
Tested with
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.0rc1/Firefox%20(1.0rc1,%20ru-RU).zip
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.0rc1/Firefox%20Setup%20(1.0rc1,%20ru-RU).exe