265341 - Warnings about unreferenced local variable from e4x in jsinterp.c

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[timeless]

r:/mozilla\js\src\jsinterp.c(1393) : warning C4101: 'name' : unreferenced local
variable
r:/mozilla\js\src\jsinterp.c(1390) : warning C4101: 'vp' : unreferenced local
variable
r:/mozilla\js\src\jsinterp.c(1394) : warning C4101: 'atom' : unreferenced local
variable

i'd suggest:

Index: jsinterp.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsinterp.c,v
retrieving revision 3.146
diff -u -r3.146 jsinterp.c
--- jsinterp.c  19 Oct 2004 01:45:44 -0000      3.146
+++ jsinterp.c  20 Oct 2004 23:12:28 -0000
@@ -1390,8 +1390,10 @@
     jsval *oldsp, *sp, *vp;
     void *mark;
     uintN i;
+#if JS_HAS_XML_SUPPORT
     const char *name;
     JSAtom *atom;
+#endif
     JSBool ok;

     fp = oldfp = cx->fp;

not sure about vp

Comment 1

[Brendan Eich [:brendan]]

Fixing with new patch for bug 246441.  Pre-closing this one ;-).

/be