265373 - compiler warnings in pki3hack on Solaris AMD64

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

"pki3hack.c", line 102: warning: implicit function declaration: NSSRWLock_LockWrite
"pki3hack.c", line 104: warning: implicit function declaration:
NSSRWLock_UnlockWrite
"pki3hack.c", line 1045: warning: implicit function declaration: NSSRWLock_LockRead
"pki3hack.c", line 1049: warning: implicit function declaration:
NSSRWLock_UnlockRead

The fix is to include nssrwlk.h , and already checked in on the tip.

Comment 1

[Julien Pierre]

Attachment: include nssrwlk.h

Comment 2

[Julien Pierre]

Checking in pki3hack.c;
/cvsroot/mozilla/security/nss/lib/pki/pki3hack.c,v  <--  pki3hack.c
new revision: 1.79.14.3; previous revision: 1.79.14.2
done

Comment 3

[Wan-Teh Chang]

This bug was introduced in rev. 1.79.14.2 of pki3hack.c,
a fix for bug 252702.  So the "bug introduced" version
is NSS 3.9.3.

Fortunately both NSSRWLock_LockWrite and NSSRWLock_LockRead
return void, so we don't need to respin NSS 3.9.3 for this.

Comment 4

[timeless]

can this be pulled to seamonkey? it's annoying.

Comment 5

[Julien Pierre]

timeless, NSS bugs are filed only against NSS releases, not browser releases. If
you want this fix in a client product, the client product needs to move up to a
tag that includes it. This was fixed in 3.9.4, so pulling NSS with a tag of
NSS_3_9_4_RTM would include this fix .

Comment 6

[Wan-Teh Chang]

I put this fix in NSS_CLIENT_TAG (Mozilla 1.8 Beta)
yesterday.