265445 - help content/contents.rdf includes chrome DTD file, really bad mojo

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Benjamin Smedberg]

/toolkit/components/help/content/contents.rdf

 42 <!DOCTYPE RDF:RDF [
 43     <!ENTITY % brandDTD SYSTEM "chrome://global/locale/brand.dtd">
 44     %brandDTD;
 45 ]>

Which means that if we register help/content before global/locale we have XML
parsing errors and we're screwed. There is no need for this entity, the
description isn't used anywhere. This causes most/all of the localized ZIP
builds to not work properly, and it may be the cause of random "my Firefox won't
start" errors for regular users.

Comment 1

[Benjamin Smedberg]

Attachment: Don't do that DTD stuff during registration

Comment 2

[Darin Fisher]

Comment on attachment 162849 [details] [diff] [review]
Don't do that DTD stuff during registration

sr=darin

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 162849 [details] [diff] [review]
Don't do that DTD stuff during registration

Agreed; please land on aviary asap.

Comment 4

[Benjamin Smedberg]

Fixed, branch and trunk

Comment 5

[Oscar Manuel Gómez Senovilla]

This is still hapenning. This bug should be reopened.