265683 - ibm.com - privacy policy viewer has transparent menu/status bar

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Ian Neal]

Using BuildID 2004102207 on RH9.0
Steps to reproduce
1. Go to above URL
2. Select View Page Info
3. Select Privacy tab
4. Click on Summary button

Expect results
1. Privacy policy viewer opens with non-transparent menu/status bars

Actual results
1. Privacy policy viewer opens with transparent menu/status bars
2. Click on links/menus that appear through the transparent parts of the privacy
policy window actually operate the links/menus

No error messages show up in the JS console

Comment 1

[Ian Neal]

Attachment: Possible patch v0.1

This patch:
* Fixes transparency by adding stylesheet and loading XPCNativeWrapper.js
* Fixes problem with printing as a result of bug 158110 being fixed
* Removes extra New Navigator from File menu
* Adds Page Setup to File menu
* Reorders File menu
* Adds charset menu to View menu
* Renames getSummaryBrowser back to getBrowser so Text Zoom works

Comment 2

[Daniel Brooks [:db48x]]

Comment on attachment 163145 [details] [diff] [review]
Possible patch v0.1

looks good, r=db48x

Comment 3

[Ian Neal]

Comment on attachment 163145 [details] [diff] [review]
Possible patch v0.1

Marking r= and requesting sr=

Comment 4

[Ian Neal]

This patch also stops Bug 265635 from happening too, something about transparent
file/status bars causes WinXP SP2 to crash in GDI32.

Comment 5

[Darin Fisher]

Comment on attachment 163145 [details] [diff] [review]
Possible patch v0.1

Asking Neil to SR instead...

Comment 6

[[e-mail]]

Comment on attachment 163145 [details] [diff] [review]
Possible patch v0.1

> <?xml version="1.0"?>
>+<?xml-stylesheet href="chrome://navigator/skin/" type="text/css"?> 
Should be after the licence. Also a trailing space crept in :-P

>+  <script type="application/x-javascript" src="chrome://global/content/XPCNativeWrapper.js"/>
So this gives us shift+clicking to save a link? Might be better to leave this
out and remove shift+clicking ;-)

>     <popup id="contentAreaContextMenu"/><!-- XXX Silly hack to quiet mailNavigatorOverlay.xul warning -->
I think this can go, mailNavigatorOverlay.xul no longer overlays
navigatorOverlay.xul

>+          <menuseparator/>
>+          <menu id="charsetMenu"/>
By my reading of the code, this didn't make sense. And that's because the
document is actually manually constructed through XSL. Changing the charset
tries to reload the document, but without the XSL...

sr=me if you fix (or argue me out of) these nits.

Comment 7

[Ian Neal]

Attachment: Revised patch v0.2

Taking on board comments

Comment 8

[Ian Neal]

Comment on attachment 163628 [details] [diff] [review]
Revised patch v0.2

Carrying forward r/sr

Comment 9

[Ian Neal]

Comment on attachment 163628 [details] [diff] [review]
Revised patch v0.2

Checking in p3pSummary.xul;
/cvsroot/mozilla/extensions/p3p/resources/content/p3pSummary.xul,v  <-- 
p3pSummary.xul
new revision: 1.3; previous revision: 1.2
done
Checking in p3pSummary.js;
/cvsroot/mozilla/extensions/p3p/resources/content/p3pSummary.js,v  <-- 
p3pSummary.js
new revision: 1.8; previous revision: 1.7
done