265686 - PK11_FindSlotByName(char *name) should be PK11_FindSlotByName(const char *name)

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[timeless]

http://landfill.mozilla.org/mxr-test/security/source/security/nss/lib/pk11wrap/pk11pub.h#98
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Fsecurity%2Fnss%2Flib%2Fpk11wrap%2Fpk11slot.c&rev=1.80&mark=574,582,592,608#572

The code doesn't change the name (nor should it), so this should take a char*

Comment 1

[timeless]

Attachment: trunk

Comment 2

[Wan-Teh Chang]

Comment on attachment 163076 [details] [diff] [review]
trunk

r=wtc.	Thanks for the patch, timeless.

Comment 3

[Wan-Teh Chang]

I checked in timeless's patch on the NSS trunk (NSS 3.10).

Checking in pk11pub.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pub.h,v  <--  pk11pub.h
new revision: 1.4; previous revision: 1.3
done
Checking in pk11slot.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.81; previous revision: 1.80
done

Comment 4

[timeless]

Attachment: nss_client_tag

Comment 5

[timeless]

Comment on attachment 163638 [details] [diff] [review]
nss_client_tag

oops, i meant to post a patch for the branch too, would it be possible for you
to apply it to nss client tag? we'd rather not work around the api if possible.

Comment 6

[Wan-Teh Chang]

Julien, can I check in this patch on the NSS_3_9_BRANCH?

Comment 7

[Julien Pierre]

Wan-Teh, this should be OK as long as it can't break any existing application
source code using this API. Going from char* const char* in this case should be
OK, I believe, so you can go ahead.

Comment 8

[Wan-Teh Chang]

timeless, can you work around this bug by casting
away the const?

Comment 9

[timeless]

i'd rather not, especially if no one objects to changing the declaration.

Comment 10

[Robert Relyea]

I think we should make this change. It doesn't break binary compatibility, or
source compatibility and it allows applications to do the right thing.

bob

Comment 11

[Wan-Teh Chang]

I checked in the patch on the NSS_3_9_BRANCH (NSS 3.9.4).

Checking in pk11func.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11func.h,v  <--  pk11func.h
new revision: 1.51.4.3; previous revision: 1.51.4.2
done
Checking in pk11slot.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.77.4.3; previous revision: 1.77.4.2
done

Comment 12

[timeless]

thanks, last step, what does it take to get NSS_CLIENT_TAG moved?

Comment 13

[Wan-Teh Chang]

Comment on attachment 163638 [details] [diff] [review]
nss_client_tag

I just checked in this patch into the NSS_CLIENT_TAG
(post Mozilla 1.8 Alpha 4).

(The SeaMonkey trunk was closed yesterday when I had
time, so I couldn't get this done yesterday.)