Closed Bug 265686 Opened 16 years ago Closed 16 years ago
_Find Slot By Name(char *name) should be PK11 _Find Slot By Name(const char *name)
http://landfill.mozilla.org/mxr-test/security/source/security/nss/lib/pk11wrap/pk11pub.h#98 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Fsecurity%2Fnss%2Flib%2Fpk11wrap%2Fpk11slot.c&rev=1.80&mark=574,582,592,608#572 The code doesn't change the name (nor should it), so this should take a char*
Summary: PK11_FindSlotByName(char *name) should be 574 PK11_FindSlotByName(const char *name) → PK11_FindSlotByName(char *name) should be PK11_FindSlotByName(const char *name)
Comment on attachment 163076 [details] [diff] [review] trunk r=wtc. Thanks for the patch, timeless.
Attachment #163076 - Flags: review+
I checked in timeless's patch on the NSS trunk (NSS 3.10). Checking in pk11pub.h; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pub.h,v <-- pk11pub.h new revision: 1.4; previous revision: 1.3 done Checking in pk11slot.c; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v <-- pk11slot.c new revision: 1.81; previous revision: 1.80 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.10
Comment on attachment 163638 [details] [diff] [review] nss_client_tag oops, i meant to post a patch for the branch too, would it be possible for you to apply it to nss client tag? we'd rather not work around the api if possible.
Attachment #163638 - Flags: review?(wchang0222)
Julien, can I check in this patch on the NSS_3_9_BRANCH?
Wan-Teh, this should be OK as long as it can't break any existing application source code using this API. Going from char* const char* in this case should be OK, I believe, so you can go ahead.
timeless, can you work around this bug by casting away the const?
i'd rather not, especially if no one objects to changing the declaration.
I think we should make this change. It doesn't break binary compatibility, or source compatibility and it allows applications to do the right thing. bob
I checked in the patch on the NSS_3_9_BRANCH (NSS 3.9.4). Checking in pk11func.h; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11func.h,v <-- pk11func.h new revision: 220.127.116.11; previous revision: 18.104.22.168 done Checking in pk11slot.c; /cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v <-- pk11slot.c new revision: 22.214.171.124; previous revision: 126.96.36.199 done
Target Milestone: 3.10 → 3.9.4
thanks, last step, what does it take to get NSS_CLIENT_TAG moved?
Comment on attachment 163638 [details] [diff] [review] nss_client_tag I just checked in this patch into the NSS_CLIENT_TAG (post Mozilla 1.8 Alpha 4). (The SeaMonkey trunk was closed yesterday when I had time, so I couldn't get this done yesterday.)
Attachment #163638 - Flags: review?(wchang0222) → review+
You need to log in before you can comment on or make changes to this bug.