Closed
Bug 265745
Opened 20 years ago
Closed 17 years ago
RelativizeURLInFragmentList forces InsertHTMLWithContext to clone its nsCOMArray<nsIDOMNode>
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: neil, Assigned: neil)
References
()
Details
(Keywords: perf)
Attachments
(1 file)
|
1.66 KB,
patch
|
Brade
:
review+
rbs
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
RelativizeURIInFragmentList's first parameter is nsCOMArray<nsIDOMNode> nodeList which means InsertHTMLWithContext has to clone its nodeList to pass it as a parameter. Instead it only needs to be a (const) reference.
|
Assignee | |
Comment 1•20 years ago
|
||
Assignee: mozeditor → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•20 years ago
|
Attachment #163127 -
Flags: superreview?(rbs)
Attachment #163127 -
Flags: review?(brade)
Comment on attachment 163127 [details] [diff] [review] Proposed patch sr=rbs
Attachment #163127 -
Flags: superreview?(rbs) → superreview+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 163127 [details] [diff] [review] Proposed patch r=brade
Attachment #163127 -
Flags: review?(brade) → review+
|
||
Updated•18 years ago
|
QA Contact: bugzilla → editor
|
||
Comment 4•17 years ago
|
||
Comment on attachment 163127 [details] [diff] [review] Proposed patch This patch is still applicable and never got checked in.
Attachment #163127 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #163127 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•17 years ago
|
||
Neil, please land this. :)
|
|
Assignee | |
Comment 6•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•