Closed Bug 265760 Opened 20 years ago Closed 19 years ago

Localizations which don't translate help or DOMI display XML parsing errors.

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

Details

(Keywords: fixed-aviary1.0, Whiteboard: [have patch] - committed on aviary, waiting for trunk to open)

Attachments

(1 file)

Localizations which *don't* translate help or DOMI come up with XML parsing
errors due to misregistered chrome in installer builds only. I'm not quite sure
why this doesn't show up in ZIP/tree builds, but we found a simple solution.

NOTE to EXTENSION AUTHORS: You will want to put similar arcs in your own
extension contents.rdf files to make sure that locales fall back correctly.
Attachment #163139 - Flags: review?(bryner)
Flags: blocking-aviary1.0+
Whiteboard: [have patch] - need review anyone (bryner) - blocks localized RC1
Comment on attachment 163139 [details] [diff] [review]
Add chrome:name to the contents.rdf files

Yeah, good fix.

That NOTE TO LOCALIZERS had better make it to m.l10n, if not also some more
permanent documentation.  And a blog post, for good measure.
Attachment #163139 - Flags: review?(bryner)
Attachment #163139 - Flags: review+
Attachment #163139 - Flags: approval-aviary+
Fixed on branch, I'll commit this on trunk once the tree opens.
Keywords: fixed-aviary1.0
Shouldn't this bug be a dupe of bug 254728?
No. This bug has a nice tight diagnosis and fix, whereas that bug is meandering.
The fact is that this problem was reported before, and now a bug is opened
stating the same problem. In abstract, this is a dupe, and the fact that in the
last bug who opened it knows how to solve it, is just a "dirty" workaround,
regardless of why it hasn't been treated the same way before.
Oscar, bugs are not abstract entities, they are used for tracking problems and
patches. It doesn't matter where the dup is marked, except that this bug has the
patch and is well documented, while that bug has a lot of cruft. It wasn't clear
to me what the problem was in bug 254728, and I'm still not sure it's the same
problem, and I couldn't reproduce it because I didn't have the proper sources.
You are welcome to resolve it fixed/worksforme/whatever if it has actually been
resolved.
Whiteboard: [have patch] - need review anyone (bryner) - blocks localized RC1 → [have patch] - committed on aviary, waiting for trunk to open
fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: