265774 - ctrl-enter on a link is nonfunctional

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Dan M]

Go to www.mozilla.org
Use the keyboard to focus a link:
  using typeahead find, type 'live
Attempt to open the link in a new tab using ctrl-enter

In an Aviary 20041021 build, the link is opened in a new page. In an Aviary
20041022 build, nothing happens.

This patch restores ctrl-enter to its 20041021 glory:

Index: browser/base/content/browser.js
===================================================================
@@ -4425,10 +4425,6 @@ function asyncOpenWebPanel(event)
  // should always return true for click to go through
  function contentAreaClick(event, fieldNormalClicks)
  {
-   if (!event.isTrusted) {
-     return true;
-   }
-
    var target = event.target;
    var linkNode;

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 163160 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 163160 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-10-23 15:29 -0700.
Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-10-23 15:30 -0700.
Fix checked in to MOZILLA_1_7_BRANCH, 2004-10-23 15:30 -0700.

Comment 5

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2004102409-0.9+ on linux fc2.