265786 - unused variable warnings in QuickDER

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P4)

Description

[Julien Pierre]

The gcc compiler generates warnings in the following :

quickder.c: In function `MatchComponentType':
quickder.c:252: warning: unused variable `tagclass'
quickder.c:253: warning: unused variable `expectedclass

The code is #ifdef DEBUG and the variables are never used indeed. For
cleanliness, I would like to eliminate the warning anyway. What's the best way
to do this ? I was thinking of assigning tagclass = tagclass and expectedclass =
expectedclass right after. Are there any compilers that will still warn on those ?

Comment 1

[Wan-Teh Chang]

A trick John Myers told me is to use the
unused variables like this:

    (void)tagclass;
    (void)expectedclass;

Perhaps you can find a more meaningful way
to use them.  I know you want to have access
to the these values in the debugger.

Comment 2

[Wan-Teh Chang]

Julien, after looking at the relevant code, I
suggest the following fix:

    unsigned char tagclass;
    unsigned char expectedclass;

    ...
  
    /* first, do a class check */  
    tagclass = tag & SEC_ASN1_CLASS_MASK;
    expectedclass = (unsigned char)kind & SEC_ASN1_CLASS_MASK;  
    if (tagclass != expectedclass)
    {
        *match = PR_FALSE;
        return SECSuccess;
    }

Comment 3

[Julien Pierre]

This bug was fixed in 3.10 .