Closed Bug 266042 Opened 20 years ago Closed 20 years ago

l10n zh-TW Trademark policy compliance

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
1.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rebron, Assigned: piaip)

References

(
URL
)

Details

Attachments

(4 files)

zh-TW Yahoo
1.40 KB, text/plain
Details
ebay Taiwan
858 bytes, text/plain
Details
The aggregated patch
10.54 KB, patch
axel
: approval-aviary+
Details | Diff | Splinter Review
Remove Yahoo Search
2.17 KB, patch
benjamin
: approval-aviary+
Details | Diff | Splinter Review 
- Remove Google US plug-in.
- Fix Googletw.src file so that <search name="Google"  and not name="Google Taiwan"
- Remove Encyclopedia and Dictionary.com search plug-ins

- Localize Yahoo, eBay, and Amazon if available.
Assignee: p_ch → piaip
Flags: blocking-aviary1.0-L10N+
Could we get a patch for this one? We would love to see zh-TW ship soon.
Attached file zh-TW Yahoo — 
- It seems that the Googletw.src is fixed in recent nightly build of zh-TW
- There's no Chinese Amazon.
- Localized Yahoo (called yahoodotzhtw.src, see the attachment) has already
placed in zh-TW builds' searchplugin folder.
- I'll try to make a localized eBay searchplugin later.

We (Mozilla Taiwan Community) would love to see zh-TW ship soon, too. ;)
Attached file ebay Taiwan — 
eBay Taiwan
- Google US is removed
- Googletw.src was already Google, not Google Taiwan
- Encyclopedia and Dictionary.com are removed
- Yahoo and ebay are localized.
- All other search plugins are now removed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
A patch that includes all issues mentioned above.
(All previous attachments can be obsoleted)
Attachment #165705 - Flags: approval-aviary?
Attachment #165579 - Attachment mime type: application/octet-stream → text/plain
Attachment #165617 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 165705 [details] [diff] [review]
The aggregated patch

post mortem approval, but this bug isn't fixed yet
Attachment #165705 - Flags: approval-aviary? → approval-aviary+
yahoo needs to be removed, just one yahoo per locale.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This has already solve in recent (13-Nov-2004) nightly builds, please label the
bug "fixed".
checked in lxr, looks good to me. rafael needs his own verification, of course.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
cc'ing Rafael since we're requesting his approval.
We can't have Yahoo in here at all.  Needs to be removed completely.  Sorry for
the confusion.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Why can't localized builds have yahoo search while the official build does? That
just doesn't make any sense. I read the webpage in the URL field .... so I need
approval from Yahoo Taiwan? 

If anyone knows the solution to this problem, please reply ASAP. We (Mozilla
Taiwan) have something important going on 8 hours later and we need a working build




This patch removes the yahoo search entry in list.txt, as well as
yahoodotzhtw.src

Please (I wish I can use bold fonts here ... ) review and check this in ASAP if
it doesn't have any problems. We (Mozilla Taiwan) need a working official
localized build 7 hours later for a Press thingy.
Attachment #166385 - Flags: approval-aviary?
Attachment #166385 - Flags: approval-aviary? → approval-aviary+
Fixed on branch
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Yahoo Search's removed, we're all set to go ;)
Mozilla/5.0 (Windows; U; Windows NT 5.2; zh-TW; rv:1.7.5) Gecko/20041119 Firefox/1.0

Let's just make this the official 1.0 localized zh-TW build :-P
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: