Closed
Bug 266042
Opened 21 years ago
Closed 21 years ago
l10n zh-TW Trademark policy compliance
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: rebron, Assigned: piaip)
References
()
Details
Attachments
(4 files)
|
1.40 KB,
text/plain
|
Details | |
|
858 bytes,
text/plain
|
Details | |
|
10.54 KB,
patch
|
axel
:
approval-aviary+
|
Details | Diff | Splinter Review |
|
2.17 KB,
patch
|
benjamin
:
approval-aviary+
|
Details | Diff | Splinter Review |
- Remove Google US plug-in.
- Fix Googletw.src file so that <search name="Google" and not name="Google Taiwan"
- Remove Encyclopedia and Dictionary.com search plug-ins
- Localize Yahoo, eBay, and Amazon if available.
Updated•21 years ago
|
Assignee: p_ch → piaip
Flags: blocking-aviary1.0-L10N+
Comment 1•21 years ago
|
||
Could we get a patch for this one? We would love to see zh-TW ship soon.
Comment 2•21 years ago
|
||
- It seems that the Googletw.src is fixed in recent nightly build of zh-TW
- There's no Chinese Amazon.
- Localized Yahoo (called yahoodotzhtw.src, see the attachment) has already
placed in zh-TW builds' searchplugin folder.
- I'll try to make a localized eBay searchplugin later.
We (Mozilla Taiwan Community) would love to see zh-TW ship soon, too. ;)
Comment 3•21 years ago
|
||
eBay Taiwan
| Assignee | ||
Comment 4•21 years ago
|
||
- Google US is removed
- Googletw.src was already Google, not Google Taiwan
- Encyclopedia and Dictionary.com are removed
- Yahoo and ebay are localized.
- All other search plugins are now removed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 5•21 years ago
|
||
A patch that includes all issues mentioned above.
(All previous attachments can be obsoleted)
| Assignee | ||
Updated•21 years ago
|
Attachment #165705 -
Flags: approval-aviary?
Updated•21 years ago
|
Attachment #165579 -
Attachment mime type: application/octet-stream → text/plain
Updated•21 years ago
|
Attachment #165617 -
Attachment mime type: application/octet-stream → text/plain
Comment 6•21 years ago
|
||
Comment on attachment 165705 [details] [diff] [review]
The aggregated patch
post mortem approval, but this bug isn't fixed yet
Attachment #165705 -
Flags: approval-aviary? → approval-aviary+
Comment 7•21 years ago
|
||
yahoo needs to be removed, just one yahoo per locale.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•21 years ago
|
||
This has already solve in recent (13-Nov-2004) nightly builds, please label the
bug "fixed".
Comment 9•21 years ago
|
||
checked in lxr, looks good to me. rafael needs his own verification, of course.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Comment 10•21 years ago
|
||
cc'ing Rafael since we're requesting his approval.
| Reporter | ||
Comment 11•21 years ago
|
||
We can't have Yahoo in here at all. Needs to be removed completely. Sorry for
the confusion.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•21 years ago
|
||
Why can't localized builds have yahoo search while the official build does? That
just doesn't make any sense. I read the webpage in the URL field .... so I need
approval from Yahoo Taiwan?
If anyone knows the solution to this problem, please reply ASAP. We (Mozilla
Taiwan) have something important going on 8 hours later and we need a working build
Comment 13•21 years ago
|
||
This patch removes the yahoo search entry in list.txt, as well as
yahoodotzhtw.src
Please (I wish I can use bold fonts here ... ) review and check this in ASAP if
it doesn't have any problems. We (Mozilla Taiwan) need a working official
localized build 7 hours later for a Press thingy.
Updated•21 years ago
|
Attachment #166385 -
Flags: approval-aviary?
Updated•21 years ago
|
Attachment #166385 -
Flags: approval-aviary? → approval-aviary+
Comment 14•21 years ago
|
||
Fixed on branch
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Comment 15•21 years ago
|
||
Yahoo Search's removed, we're all set to go ;)
Mozilla/5.0 (Windows; U; Windows NT 5.2; zh-TW; rv:1.7.5) Gecko/20041119 Firefox/1.0
Let's just make this the official 1.0 localized zh-TW build :-P
You need to log in
before you can comment on or make changes to this bug.
Description
•