Closed
Bug 266118
Opened 21 years ago
Closed 21 years ago
Comment and code do not agree in nsXFormsInputElement
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: bryner)
References
()
Details
Attachments
(1 file)
|
805 bytes,
patch
|
smaug
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
nsXFormsInputElement::OnCreated() states:
--- CUT ---
// It's ok to keep a weak pointer to mElement. mElement will have an
// owning reference to this object, so as long as we null out mElement in
// OnDestroyed, it will always be valid.
--- CUT ---
But nsXFormsInputElement::OnDestroyed() does not contain |mElement = nsnull;| ...
|
Reporter | |
Comment 1•21 years ago
|
||
The patch in bug 271737, includes a fix for this
Depends on: 271737
|
|
Reporter | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 2•21 years ago
|
||
|
|
Reporter | |
Comment 3•21 years ago
|
||
Comment on attachment 168609 [details] [diff] [review]
Fix
Newest path for bug 271737, does not include patch for this anymore.
Attachment #168609 -
Flags: superreview?(darin)
Attachment #168609 -
Flags: review?(smaug)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 168609 [details] [diff] [review]
Fix
This is ok.
Another thing is that RemoveEventListener should actually happen in
WillChangeDocument.
Attachment #168609 -
Flags: review?(smaug) → review+
|
||
Updated•21 years ago
|
Attachment #168609 -
Flags: superreview?(darin) → superreview+
|
|
Reporter | |
Comment 5•21 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•