266143 - If Param("usevotes") is off, editing a product should mention it

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Axel Wagner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7) Gecko/20040803 Firefox/0.9.3

I turned voting off on our Bugzilla installation (usevotes off). However, the
pages to create or edit new products still show the votes elements and waste
screen space.
I think that some "if (Param('usevotes'))" in editproducts.cgi could correct this. 

Reproducible: Always
Steps to Reproduce:
1. Turn off usevotes
2. Open the products list and edit a product

Actual Results:  
The "Select product" page as well as the "Edit product" page still show voting
elements.


Expected Results:  
Do not display the voting elements.

Comment 1

[Frédéric Buclin]

I think it's fine having these columns shown even if you don't need them. This
way, you can configure vote properties while votes are off, and turn them on
only when the configuration you want is done.

Comment 2

[A. Karl Kornel]

Suggest WONTFIX as per comment 1.

I'd be more concerned if this was a user-facing page, but since it isn't this
doesn't seem as bad.

Comment 3

[Max Kanat-Alexander]

I dunnow, I think those elements could be confusing, if you didn't enable
voting. It's up to Myk whether or not we want to do it.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

We shouldn't eliminate vote configuration UI completely.  As Frederic notes,
it's useful to be able to configure voting per-product before enabling the
feature, and it also makes the feature more discoverable.

But it would be useful to indicate that voting is disabled, and in certain
designs of these pages it might also be possible to collapse the vote
configuration fields into a single header that takes up little space but expands
when clicked upon to show the fields available.

Comment 5

[GavinS]

Attachment: Indicate that voting is disabled on editproducts

Comment 6

[Frédéric Buclin]

Comment on attachment 194758 [details] [diff] [review]
Indicate that voting is disabled on editproducts

>Index: template/en/default/admin/products/edit.html.tmpl

> [% PROCESS global/header.html.tmpl
>   title = title
>+  style_urls = ['skins/standard/admin.css']
> %]

template/en/default/admin/products/create.html.tmpl needs this CSS too. This can be fixed on checkin (or even better: update your patch and carry forward my r+). r=LpSolit

Comment 7

[Frédéric Buclin]

Attachment: patch checked in

updated patch with create.html.tmpl added.

Comment 8

[Frédéric Buclin]

Checking in skins/standard/admin.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/admin.css,v  <--  admin.css
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/products/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/products/edit-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl,v  <--  edit-common.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/products/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done