266199 - Figure out User-Agent string's rv: version for Firefox 1.0 release

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Marcia Knous [:marcia]]

As discussed at today's Aviary meeting. Will be discussed next week.

Comment 1

[Steffen Wilberg]

What is "RV"?

Comment 2

[sfmag]

I guess they're going to paint an RV in pice pretty FireFox colors and drive it
around picking up chicks... or something. ;-P

Comment 3

[Maarten Geurts]

http://www.google.com/search?q=define%3Arv

I go for the "ICBM Re-entry Vehicle containing the nuclear warhead(s). " Since
it best fits the bang" 

(however checking bugzilla shows that rv mostly stands for Return value. Note
that this is a Macos X bug) 

Comment 4

[gumpish]

(In reply to comment #3)
> (however checking bugzilla shows that rv mostly stands for Return value. Note
> that this is a Macos X bug) 

I'm no bugzilla genious, but isn't that what the blocking-aviary1.0mac flag is for?

Comment 5

[Jeff Walden [:Waldo]]

(In reply to comment #4)
(In reply to comment #3)
(In reply to comment #2)

I'm no genius either, but it doesn't take much to see that not one of these
comments was useful either for the developers or the people cc'd to this bug. 
Please don't add comments if your comment doesn't add to this bug in some
meaningful way.

Comment 6

[Worcester12345]

Yeah, like this one? https://bugzilla.mozilla.org/show_bug.cgi?id=122411

(Maybe the RV needs a kitchen sink.)

Comment 7

[[e-mail]]

(In reply to comment #5)
> (In reply to comment #4)
> (In reply to comment #3)
> (In reply to comment #2)
> 
> I'm no genius either, but it doesn't take much to see that not one of these
> comments was useful either for the developers or the people cc'd to this bug. 
> Please don't add comments if your comment doesn't add to this bug in some
> meaningful way.

Maybe these comments could have been avoided if the original poster of the bug
would have given some real information about the bug instead of simply writing
"as discussed...". 

Comment 8

[Bradley Chapman (not reading bugmail, still gone but not forever)]

For those of you who do not know, the rv: string is the version number of the
equivalent Mozilla release that would have been built from the source code used
to build any version of Firefox with the matching rv:.

For example: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041030
Firefox/1.0RC2 (daihard: P4/SSE2) indicates that if the same source used to
build this nightly were used to build Mozilla, you would get Mozilla v1.7.3.

Will the rv: be in thw 1.7.X group?

Comment 9

[Bill Gianopoulos [:WG9s]]

Well, in my opionon it is a bit late in the game to be changing this now.  I
would think a change in the UI rv would be kind of a risky change.  For example,
if it is decided to change it to be the firefox version and change it to version
1.0, then a bunch of browser version sniffing JavaScript code is going to decide
the browser is Mozilla Version 1.0 which the site does not support and all of a
sudden there will be sites all over the Internet that worked just fine with the
PR realese and RC1that suddenly start telling everyone that their browser is too
old and they need to get a new one.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I don't think it's risky to change 1.7.3 to 1.7.5, which is the most likely choice.

Comment 11

[Bill Gianopoulos [:WG9s]]

re comment #10 I don't see that as being any risk.  That has certainly been done
before.  Just seeing we are going to change it and there was discussion just
made me fear it was going to be the firefox version rather than the core code
version which would make it go to 1.0 which I was pretty sure would break thinhgs.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the consensus we were leaning towards when this was last discussed was
to use 1.7.5 for the following reasons:
 * it leaves room for a 1.7.4 security release based on 1.7.3 if we need to do one
 * if we don't have a 1.7.4 security release, it indicates that it's a little
more than a normal dot release for when we do a MOZILLA_1_7_BRANCH-based release
that's Gecko-equivalent to the Aviary 1.0 releases.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 164231 [details] [diff] [review]
patch

r+a=[e-mail]

Comment 15

[Steffen Wilberg]

No aviary checkin yet. Reopening.

Comment 16

[Steffen Wilberg]

Oops, sorry.

Comment 17

[sairuh (rarely reading bugmail)]

rv: 1.7.5 in today's firefox aviary1.0 build (2004110309-0.11, linux fc2).
vrfy'ing fixed.