266525 - Plugin finder does not work when a page with plugin is opened in background tab

Status: VERIFIED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[Pavel Penaz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0

When I open a page with a plugin in a background tab, clicking on the "Install
missing plugin" button does not do anything, the plugin information bar just
disappears.

Reproducible: Always
Steps to Reproduce:
1. Have tabs set to open in the background
2. Open http://www.macromedia.com/shockwave/welcome/ in tab
3. Click on the button "Install missing plugin"

Actual Results:  
Plugin information bar disappears

Expected Results:  
Plugin finder should be invoked

Comment 1

[Pavel Penaz]

I should probably add that you have to wait till the page fully loads in the
background tab. If you switch to the tab before the page fully loads, the plugin
finder works as expected.

Comment 2

[Peter van der Woude [:Peter6]]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041028
Firefox/1.0RC1

Confirming
open the testcase in a background tab and try to find the missing plugin
->NEW

Comment 3

[Pavel Penaz]

Thanks Peter for confirming the bug. I guess this is a rather serious issue,
nominating for blocking FF1.0.

Comment 4

[Philip Rinn]

Hm, WFM using testcase
plugin finder pops up and tells me "No suiteable plugins were found."
Plugin information bar does not disappear.
Didn't use a new profile.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026
Firefox/1.0RC1

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> Hm, WFM using testcase
> plugin finder pops up and tells me "No suiteable plugins were found."
> Plugin information bar does not disappear.
> Didn't use a new profile.
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026
> Firefox/1.0RC1
Open in background, not foreground

Comment 6

[Philip Rinn]

(In reply to comment #5)

> Open in background, not foreground
> 
I did that

Comment 7

[Philip Rinn]

Ups, clicked on "Click here to download plugin" :o(. sorry!
Confirm this bug when using "Install missing plugin"

Comment 8

[Doron Rosenberg (IBM)]

not really a blocker, tabs are an advanced user feature.

Comment 9

[Doron Rosenberg (IBM)]

this is caused by a tabbrowser "feature" - selecting a tab fires
onLocationChange, and the pfs clears its list, as its expecting a new URL to
have loaded.

Comment 10

[Doron Rosenberg (IBM)]

Attachment: Patch - move clearing to startDocumentLoad

Comment 11

[Doron Rosenberg (IBM)]

Attachment: move clearing to startDocumentLoad and move closing message to pfs code.

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 164414 [details] [diff] [review]
move clearing to startDocumentLoad and move closing message to pfs code.

- In pluginInstallerWizard.js:

>+    window.opener.getBrowser().hideMessage(window.opener.getBrowser().selectedBrowser, "top");
>     window.opener.getBrowser().reloadTab(gPluginInstaller.mTab);

Might want to store window.opener.getBrowser() in a local here to avoid calling
it 3 times in a row...

r+sr=jst

Comment 13

[Doron Rosenberg (IBM)]

Comment on attachment 164414 [details] [diff] [review]
move clearing to startDocumentLoad and move closing message to pfs code.

dunno if 1.0 wants this.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 164414 [details] [diff] [review]
move clearing to startDocumentLoad and move closing message to pfs code.

too late for 1.0.

Comment 15

[Michael Lefevre]

in that case, this can't be a blocker for 1.0.

Comment 16

[Pavel Penaz]

Could this be checked into Aviary now, is it safe enough? Thanks

Comment 17

[Doron Rosenberg (IBM)]

Its up to aviary drivers to decide.

Comment 18

[Doron Rosenberg (IBM)]

targetting 1.1

Comment 19

[David Brigada]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041118 Firefox/1.0

Confirmed on Linux, too.

Comment 20

[Doron Rosenberg (IBM)]

checked in.

Comment 21

[Pavel Penaz]

-> VERIFIED