266538 - state of Highlight button should be remembered

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement, P3)

Description

[Mugros]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

I would like to see that FF remembers the state of the "Highlight"-Button

Reproducible: Always
Steps to Reproduce:
1. Search for a string
2. highlight it
3. close browser
4. open browser
5. search again

Actual Results:  
Highlight was turned of

Expected Results:  
leave Highlight aktivated

Comment 1

[Bram van Leur]

I would really like it to keep current behaviour, so if it is changed I vote for
a preference (defaulting to current).

Sounds like INVALID to me anyway.

Comment 2

[Mugros]

An option would be ok, whether to remember its state or reset it.

I entered it as an enhancement, so it is not INVALID.
They could change it to WONTFIX, but i would really like to see this option.

quote:
"Not all 'bugs' are bugs. Some items in the database are known as Enhancement
Requests or Requests For Enhancement (RFE). An RFE  is a bug whose severity
field is set to 'enhancement'. People often say 'bug' when they mean 'item in
Bugzilla', so RFEs often wind up being called bugs."

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Mugros]

Oh yes, i still strongly recommend to add this improvement.

Comment 5

[Peter van der Woude [:Peter6]]

this is wontfix

if highlight is ON by default and you type e.g. a first letter "e" on a
large/huge page it'll take ages before the painting is finished and you can
continue typing.

Comment 6

[Mugros]

I disagree with this wontfix argument.

It should be easy to check the search strings length and enable automatic
highlighting after a length of e.g. 3 characters. That should be one line of
code. (Or deactivate highlight all if the page exceeds a certain size)
And most of the time i search on normal size pages and there is no noticable
delay. Permanent automatic highlighting would be useful in 99% of the cases. The
remaining 1% because of the huge pages should not be the only reason for a wontfix.

"Highlight all" isn't even deactivated if i shorten the search string or clear
it and begin a new search. It the delay would be so bad, they should
automatically deactivate highlighting if the search string becomes small.

I don't say that this should be the default, just make it an option. It could
even be hidden in about:config.

Comment 7

[Mugros]

The long delay if you have many matches is also reported as a bug
https://bugzilla.mozilla.org/show_bug.cgi?id=251862
If this enhancement is marked as WONTFIX than that bug should also be marked as
WONTFIX.
And every user should know that searches for a common string on a huge webpage
does take time. If he don't want these delays he can disable highlight all.
Before searching a huge page the user could open the find bar, disable
highlighting and then start his search. 

Comment 8

[Ian Macfarlane]

Suggest change summary to "state of Highlight button should be remembered after restarting browser"

Comment 9

[George R. Goffe]

I have this problem on my various Linux and Unix systems and have NEVER
seen degradation caused by browsing large pages and using the find process. 
I personally feel that remembering highlighting settings should be a fact of 
life and is, in fact, a bug if it's not remembered.

Comment 10

[Mike de Boer [:mikedeboer]]

This has been fixed in the meantime.