266583 - additional tab opened when ctrl+clicking a link which opens another window

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004102809-0.11 on linux fc2. asa also sees this on winXP.

1. pref settings:

a. force links which open new windows to open in new tabs
b. do not select new tabs opened from links

2. go to a web page containing links which open into new windows, eg:
http://sfgate.com then click on the "day in pictures" image link (on the right,
near the top of the page).

3. ctrl+click that link.

expected: open the link in a new tab in the background.

actual results: two tabs open!

* one tab opens in foreground which is untitled (blank)
* a second tab correctly opens in the background with the "day in pictures" content

side note: ctrl+shift+clicking has the same result, except that the 2nd tab
opens in the foreground (expected, except for the extra blank tab).

Comment 1

[Tracy Walker [:tracy]]

I believe this is a dupe of either bug 138198 or 182300.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

*** Bug 272521 has been marked as a duplicate of this bug. ***

Comment 3

[Matthew Woehlke]

Bug 272521 is slightly different... that one is an example of both tabs opening
to the correct page, not one correct and one blank.

There was a similar bug - which it seems I can no longer locate - where
middle-clicking caused the same problem, which was partly resolved two years ago
IIRC.

Anyway, the fix should be the same for both of these: ctrl+click on links (and
*only* on links) should be treated as middle-click.

Comment 4

[Wim Hueskes]

Attachment: testcase

Relevant code:

<a href="http://slashdot.org/" target="thisanewwindow" 
   onclick="window.open('', 'thisanewwindow', 
   'top=10,left=10,width=580,height=420'); return true;">

First the onclick is executed. A popup with a blank url is opened, and true is returnes, so the href is executed. It's target is the popupwindow. But instead it is opened in a new tab.

when middle clicking, it just opens a new tab, because onclick is not executed.
when left clicking w/o ctrl the page is opened in the popup.

In my opinion this is either a duplicate of bug 151142 (modifier+click on a link (ctrl, shift) should not generate onclick event for links) - then it will behave like a middle click, or bug 121377 (tabs not reused when they should be) - then it will behave like a normal left click.

Comment 5

[Worcester12345]

http://www.cusser.net/extensions/disabletarget/

?

Comment 6

[Worcester12345]

Version should be changed to reflect current shipping version, no?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Using the following URL in the location bar,
> data:text/html,<a href="http://www.google.com" target="_blank">google</a>
and ctrl+clicking on the link I am unable to reproduce this bug in Nightly 21. I only get one tab.