266667 - keyword search should not escape strings inputed into unicode

Status: RESOLVED DUPLICATE of bug 258223

(Firefox :: General, defect)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

In 1.0PR, it does not escape the strings inputed into unicode so that the
location bar.
However, it does in 1.0RC1.
It makes many websites(e.g. CJK sites) which does not accept non-unicode strings
do not work.

Reproducible: Always
Steps to Reproduce:
1. add this URL(http://google.com.hk/search?q=%s&ie=Big5&oe=UTF-8) as keyword
search which only accept Big5 encoding.
2. change the system locale to Big5 encoding.
3. use this keyword search with string "中文" via location bar.

Actual Results:  
It lists results of "銝剜   ".(due to "中文" has been escaped as unicode before
forward the URL)

Expected Results:  
It should list results of "中文".

Comment 1

[Sekundes]

Please use "UTF-8" encoding to view this page, thanks.

Comment 2

[Robin Monks]

*** Bug 266669 has been marked as a duplicate of this bug. ***

Comment 3

[Jungshik Shin]

> add this URL(http://google.com.hk/search?q=%s&ie=Big5&oe=UTF-8) as keyword

Why on earth do you want to do this? There's ABSOLUTELY NO reason to set the
above when 
'http://google.com.hk/search?q=%s&ie=UTF-8&oe=UTF-8' work perfectly well.
However, for 'local search engines' that don't understand UTF-8, we need a way
to specify the character encoding to use. That's bug 258223.

*** This bug has been marked as a duplicate of 258223 ***

Comment 4

[Sekundes]

(In reply to comment #3)
> > add this URL(http://google.com.hk/search?q=%s&ie=Big5&oe=UTF-8) as keyword
> 
> Why on earth do you want to do this? There's ABSOLUTELY NO reason to set the
> above when 
> 'http://google.com.hk/search?q=%s&ie=UTF-8&oe=UTF-8' work perfectly well.
> However, for 'local search engines' that don't understand UTF-8, we need a way
> to specify the character encoding to use. That's bug 258223.
> 
> *** This bug has been marked as a duplicate of 258223 ***

I just want to make an example that accept Big5 encoding strings only.
I have lots of keyword search like this.
However, I want to know why it was change since 1.0PR?
This works different between 1.0PR and 1.0RC1.

Comment 5

[Jungshik Shin]

(In reply to comment #4)

> I just want to make an example that accept Big5 encoding strings only.
> I have lots of keyword search like this.

That's what bug 258223 is for. 

> However, I want to know why it was change since 1.0PR?
> This works different between 1.0PR and 1.0RC1.

 What change are you talking about? It's always been like this afaik.

Comment 6

[Jungshik Shin]

(In reply to comment #5)

> > However, I want to know why it was change since 1.0PR?
> > This works different between 1.0PR and 1.0RC1.
> 
>  What change are you talking about? It's always been like this afaik.

Sorry. You're right. I forgot what I wrote in bug 258223 comment #14:

> (currently, we always conver to the platform encoding)

It seems like one of firefox peers checked in the equivalent of attachment
158088 [details] [diff] [review] without any review. I'll add more comment to bug 258223

Comment 7

[Jungshik Shin]

(In reply to comment #6)

> It seems like one of firefox peers checked in the equivalent of attachment
> 158088 without any review. I'll add more comment to bug 258223

Indeed, it was (although it was reviewed). See 

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=browser.js&branch=&root=/cvsroot&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&rev1=1.346&rev2=1.347