266759 - Disable Single Window Mode by default for 1.0

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

There are recurring crashes related to single window mode in Firefox... we're
not having an easy time reproducing them and there are numerous issues
(window.close not working right etc)... as a result we've decided to disable the
UI that lets you set single window mode preferences for Firefox 1.0...

the disabling is being done off a pref, browser.tabs.showSingleWindowModePrefs,
which when set to true via about:config will show the UI again.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to disable UI based on a pref

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 163887 [details] [diff] [review]
patch to disable UI based on a pref

+  // XXXben - Hide Single Window mode prefs for 1.0
+  var tabbedOpenForce = document.getElementById("tabbedOpenForce");
+  var tabbedWindowLinks = document.getElementById("tabbedWindowLinks");
+  if (parent.hPrefWindow.getPref("bool",
"browser.tabs.showSingleWindowModePrefs", false)) {
+    tabbedOpenForce.hidden = false;
+    tabbedWindowLinks.hidden = false;
+  }

You could declare the two local variables inside the if check since they're not
used outside of it.

sr=jst either way tho.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

consolidate.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 163890 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 5

[sairuh (rarely reading bugmail)]

yup, the UI is hidden: vrfy'd fixed with 200411030x-0.11 on linux fc2 and mac os
x 10.3.5.

Comment 6

[Jonathan David Bloom]

It's not disabled for me and I like it not being disabled.

Comment 7

[amano]

@fantasai: Shouldn't that be re-enabled on the trunk (eg for crash testing!)? It
is disabled now since the aviary branch landing.