266873 - "ASSERTION: nsAppStartup not thread-safe" when accessing IMAP mail server

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Mark Banner (:standard8)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8a5) Gecko/20041017
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041029

Every time I perform an action to access an IMAP mail server, I get multiples of
the following  assertion on the console window:

###!!! ASSERTION: nsAppStartup not thread-safe: '_mOwningThread.GetThread() ==
PR_GetCurrentThread()', file nsAppStartup.cpp, line 101


Reproducible: Always
Steps to Reproduce:
1. Start mozilla mail
2. Select IMAP account
3. Select search and search for an item

Actual Results:  
During steps 2 and 3, multiple assertions as given above were received on the
console.

Expected Results:  
Not given an assertion. 

I think this is a problem caused by bug 237745. It wasn't here yesterday (before
the bug was checked in).

IMAP still seems to work ok though.

Comment 1

[Benjamin Smedberg]

Darin, you made me remove the THREADSAFE_ISUPPORTS from app-startup, and this is
what you get :-P . Do you want to really fix the problem or wallpaper over it
with IMPL_THREADSAFE_ISUPPORTS?

Comment 2

[[e-mail]]

Attachment: Stack trace

Comment 3

[Benjamin Smedberg]

darin, for your reference, this happens because we are observing the
"nsIEventQueueActivated" observer-service topic at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/startup/src/nsAppStartup.cpp&rev=1.1&mark=953-961#949

So the proxying itself is fine, it's the event queue created by the proxy code
which is causing the problem. Does app-startup need to know anything about event
queues which aren't on the main thread?

Comment 4

[Mark Banner (:standard8)]

I believe that the fix for bug 234620 also fixed this bug, and I can confirm
that in the following build the assertion does not occur:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041104

I believe the patch that fixed it was:
2004-11-03 18:34 mozilla/ xpcom/ threads/ nsEventQueue.cpp 3.42
fixes bug 234620 "Unknown random SEGV/seg fault/core dumps/crashes, only thing
on is Mail/IMAP" r=dbaron sr=bienvenu

Therefore Marking as fixed. Please reopen if anyone disagrees.