266910 - Navigating location bar history w/ keyboard drops www/ftp prefix from displayed address

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[zuziak]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

When navigating the location bar history with the keyboard (arrow up/down) the
address shown in the location bar does not include any www or ftp prefix from
the entry.

If you press enter to go to an url from the history firefox actually goes to the
saved url (with www or ftp prefixed) and not the one displayed (without
www/ftp). This is good.

But is you modify the selected url, eg. change the filename you want to go to
firefox goes to the "wrong" url, the url displayed without the www prefix.

This is unfortunate. If you want to go to an url on the same site as one in your
history you can save a lot of typing by just modifying a history item. But
because of this bug you have to manually prepend www. Not a big problem but a
bit annoying.

Reproducible: Always
Steps to Reproduce:
1. Clear the location bar history.
2. Enter url http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/ and go.
3. Enter the url fon another site, eg. www.userfriendly.org and go.
4. Type ctrl-l to activate the location bar and type mozil and press arrow down
   to highlight http://ftp.mozilla.org ... /nightly/. In the location bar only
   mozilla.org ... /nightly/ is shown.
5. Type contrib to append this to the url in the location bar. Go.

Actual Results:  
You get a 404 error from www.mozilla.org (expanded from mozilla.org) that the
given page wasn't found.

Expected Results:  
Firefox should have displayed the entire url (including ftp.) when the history
item was selected. That way you would get to the ftp.mozilla.org page you really
wanted.

Comment 1

[zuziak]

I have just confirmed this bug on Windows 2003 Server with Firefox 1.0. I'm
assuming the bug affects other platforms too.

Comment 2

[Ivan Bútora]

Confirmed on Windows 98 SE:

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

Comment 3

[Nikola Kocić]

Confirmed on Windows XP Pro SP2

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050924
Firefox/1.4 ID:2005092406

Comment 4

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Confirmed again.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20050928 Firefox/1.4
ID:2005092805

I can't decide if this bug is annoying enough to possibly block 1.8b5.

Comment 5

[Ronny Perinke]

Attachment: proposed patch

In such cases like the test-case, the searchresult string does not start with
the searchstring. The string which will be put into the urlbar is cut off at
the beginning (the part which differs and this is http://www. in most cases).

This patch removes the check whether or not the beginning of the result matches
the beginning of the searchstring. I've tested it with my own linux and windows
builds and I could not find any side-effects.

Comment 6

[Son Le]

Try [e-mail] or [e-mail] instead of Ben for a quicker response.

Comment 7

[Roy Tam]

(In reply to comment #5)
> Created an attachment (id=200440) [edit]
> proposed patch
> 
> In such cases like the test-case, the searchresult string does not start with
> the searchstring. The string which will be put into the urlbar is cut off at
> the beginning (the part which differs and this is http://www. in most cases).
> 
> This patch removes the check whether or not the beginning of the result matches
> the beginning of the searchstring. I've tested it with my own linux and windows
> builds and I could not find any side-effects.

I think this patch needs revised.
After applying this patch the auto-complete acts very different from original.
The selected text needs modifying.
e.g. if I input "g" I will get "http://www.google.com/".
But the selected is "ttp://www.google.com/" and leave the first letter unselected.

For the best and original-liked effect, the selected text is "oogle.com/" and "http://www.g" is unselected IMHO.

Comment 8

[Roy Tam]

Attachment: Revised patch

A revised patch suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=266910#c7

Comment 9

[David P James]

Mass edit: Changing QA to default QA Contact

Comment 10

[David P James]

Mass edit: Setting correct QA for location bar/autocomplete. My bad. I forgot I had once been Autocomplete QA too. Hmm, why can't I just set the QA of bugs to the default QA of the component in a mass edit rather than having to do it manually...?

Comment 11

[Peter Kasting]

I can't reproduce this bug on the trunk or branch using the steps to reproduce in comment 0.  I strongly suspect it was fixed by one of my urlbar autocomplete fixes.

If someone else can confirm this, or else let me know what I've missed in reproducing, that would be awesome.  If I don't hear anything within a week or so, I'll close WORKSFORME.

Comment 12

[Nikola Kocić]

Also WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060706 BonEcho/2.0a3 - Build ID: 2006070603

Comment 13

[Peter Kasting]

OK, since one of the original confirmers has now confirmed WFM, I'm closing this.

I made a couple fixes that should have solved several urlbar autocomplete issues similar to this on both trunk and branch, so more testing there will always be welcome.