Closed Bug 266954 Opened 20 years ago Closed 20 years ago

a few default bookmarks are missing titles

Categories

(Firefox :: General, defect)

1.0 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Keywords: fixed-aviary1.0, regression, Whiteboard: [needs to be checked in])

Attachments

(1 file)

found using 2004103009-0.11 on linux fc2, using a new profile. couldn't find an existing bug for this, but dup or reassign as needed. 1. open the bookmarks menu, bookmarks manager or bookmarks sidebar. 2. expand either the Quick Searches or Firefox and Mozilla Links folders. * Quick Searches entry for http://www.google.com/search?q=%s has an empty name (title) --perhaps it should say something like "Google Stock Quote Quicksearch" * Firefox and Mozilla Links entry for http://www.mozillazine.org/ also has an empty name --the title should prolly say something like "MozillaZine"
wasn't a problem with 1.0RC1 bits, so this regressed recently. perhaps due to the fix for bug 266457?
Flags: blocking-aviary1.0?
Keywords: regression
yesterday's build 2004102909-0.11 doesn't exhibit this.
Summary: a few default bookmarks missing titles → a few default bookmarks are missing titles
Flags: blocking-aviary1.0? → blocking-aviary1.0+
OS: Linux → All
Hardware: PC → All
It appears the patch checked in for bug 266457 inadvertantly added some hard line breaks that should not be there.
Attached patch FixSplinter Review
This fixes the missing titles and the broken stock quote search. It did a regular Google search before, it now goes specifically to the stock quote page.
Attachment #164145 - Flags: review?(bugs) → review?(vladimir)
Punting to General; Bookmarks = Bookmarks code, not default bookmarks.
Assignee: vladimir → firefox
Component: Bookmarks → General
QA Contact: mconnor → firefox.general
Comment on attachment 164145 [details] [diff] [review] Fix a=asa for aviary checkin.
Attachment #164145 - Flags: approval-aviary+
I have no CVS access, please checkin.
Whiteboard: [needs to be checked in]
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 267256 has been marked as a duplicate of this bug. ***
Keywords: fixed-aviary1.0
looks good --vrfy'd fixed with 2004110309-0.11 (linux fc2) with a new profile.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: