26719 - Memory leak mozilla/widget/src/windows/nsFileWidget.cpp

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Bruce Robson]

Memory leak mozilla/widget/src/windows/nsFileWidget.cpp 

function nsFileWidget::GetFolder calls the Win32 API function
::SHBrowseForFolder which returns a pointer of type LPITEMIDLIST.
This is at line 326.

I believe the caller is responsible for freeing the memory pointed
to. This is not happening.

Comment 1

[Peter Trudelle]

reassigning to sdagley. Steve, if this is non-trivial please let me know.

Comment 2

[Bruce Robson]

http://support.microsoft.com/support/kb/articles/Q179/3/78.ASP shows use of 
SHGetMalloc to get the shell’s IMalloc interface and use of this interface to 
free the result returned from SHBrowseForFolder.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: a patch

Comment 4

[Paul MacQuiddy]

*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
[e-mail]

Comment 5

[Peter Trudelle]

reassigning to danm

Comment 6

[Peter Trudelle]

Mass-moving all M16 non-feature bugs to M17, which we still consider to be 
part of beta2

Comment 7

[Peter Trudelle]

moving to m18, since it is reported as minor

Comment 8

[Peter Trudelle]

mass-moving all bugs to m21 that are not dofood+, or nsbeta2+

Comment 9

[Judson Valeski]

taking.

Comment 10

[Judson Valeski]

I'll apply the patch.

Comment 11

[Judson Valeski]

fix is in.

Comment 12

[shrirang khanzode]

verified that patch is in with version 3.37 in the tree. Marking VERIFIED