267195 - implement svg opacity property

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Comment 1

[tor]

Attachment: opacity snapshot (cairo only)

Comment 2

[tor]

Attachment: tweak for <svg:image> usage

Comment 3

[tor]

Attachment: snapshot (cairo and gdi+ support)

Comment 4

[tor]

Attachment: cleanup and stub libart

Comment 5

[tor]

Attachment: small tweak

Comment 6

[Scooter Morris]

Comment on attachment 166283 [details] [diff] [review]
small tweak


>Index: layout/svg/renderer/public/nsISVGRendererCanvas.idl
>===================================================================

Fix indentation...

>+  void compositeSurfaceMatrix(in nsISVGRendererSurface surface,
>+                        in nsIDOMSVGMatrix canvasTM,
>+                        in float opacity);

>Index: layout/svg/renderer/src/cairo/nsSVGCairoCanvas.cpp
>===================================================================

Fix indentation...

>+NS_IMETHODIMP
>+nsSVGCairoCanvas::CompositeSurfaceMatrix(nsISVGRendererSurface *aSurface,
>+                                   nsIDOMSVGMatrix *aCTM, float aOpacity)
>+{

>Index: layout/svg/renderer/src/cairo/nsSVGCairoSurface.cpp
>===================================================================

Indentation....

>+
>+nsresult
>+NS_NewSVGCairoSurface(nsISVGRendererSurface **result,
>+                     PRUint32 width, PRUint32 height)
>+{

Don't we usually indent MAP_ENTRYs?

>+
>+NS_INTERFACE_MAP_BEGIN(nsSVGCairoSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISVGRendererSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISVGCairoSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISupports)
>+NS_INTERFACE_MAP_END
>+

>Index: layout/svg/renderer/src/cairo/nsSVGCairoSurface.h
>===================================================================

Indentation...

>+
>+nsresult
>+NS_NewSVGCairoSurface(nsISVGRendererSurface **result,
>+		      PRUint32 width, PRUint32 height);

>Index: layout/svg/renderer/src/gdiplus/nsSVGGDIPlusSurface.cpp
>===================================================================

Again, shouldn't the MAP_ENTRY's be indented?

>+
>+NS_INTERFACE_MAP_BEGIN(nsSVGGDIPlusSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISVGRendererSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISVGGDIPlusSurface)
>+NS_INTERFACE_MAP_ENTRY(nsISupports)
>+NS_INTERFACE_MAP_END
>+

>Index: layout/svg/renderer/src/libart/nsSVGLibartCanvas.cpp
>===================================================================

Indentation....

> NS_IMETHODIMP
> nsSVGLibartCanvas::SetClipRect(nsIDOMSVGMatrix *aCTM, float aX, float aY,
>                               float aWidth, float aHeight)
> {

Comment 7

[tor]

Checked in.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why were GetStrokeOpacity and GetFillOpacity changed to multiply by the
mOpacity?  They're separate concepts -- isn't opacity implemented (using a
push/pop API) in such a way that you don't need to do this?

Comment 9

[tor]

Because you can specify opacity on a leaf geometry element and it's much
cheaper to draw with the combined opacity rather than do the surface
push/pop, and it gives the same result.